12014 Commits

Author SHA1 Message Date
LibretroAdmin
6ad88b080e Turn these two fill_pathname_join_delim() calls into plain strlcat() 2022-08-04 15:15:27 +02:00
LibretroAdmin
b2634ea588 * Create fill_pathname_join_special - and specify fill_pathname_join
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00
LibretroAdmin
88bc26da4e Replace some more trivial strlcat calls 2022-08-04 04:05:27 +02:00
LibretroAdmin
e7f3432e48 Replace some trivial strlcat usage - use return value of preceding
strlcpy then simply append the extension to it at this location
2022-08-04 03:45:09 +02:00
LibretroAdmin
02df727cb2 Avoid strtof() since it's C99/POSIX. Go for strtod followed by float
cast since it should be almost identical
2022-08-03 14:07:32 +02:00
LibretroAdmin
6dd52d9bb1 Get rid of more boilerplate code in file_path_special.c 2022-08-02 18:05:51 +02:00
LibretroAdmin
556e6702ef Start downscaling on file_path_special.c 2022-08-02 17:54:38 +02:00
LibretroAdmin
70ca20fbf9 (MaterialUI) Fix earlier mistakes made (cd04f770b9a5b6d35df67ff38d89694cee561750) -
we need two separate icon paths cached - one for MaterialUI and one for Ozone (the system
icons)x
2022-08-02 17:25:52 +02:00
Cthulhu-throwaway
8105688a99
(Netplay) Show client slowdown information (#14272) 2022-08-02 13:31:55 +02:00
Cthulhu-throwaway
20c4407928
Add HAVE_IFINFO macro (#14265) 2022-08-01 07:51:02 +02:00
LibretroAdmin
f472e4d0de (gfx_widgets) Call fill_pathname_application_special outside of hot functions
(gfx widgets) Pre-assemble and store paths that are not subject to change
2022-08-01 02:07:36 +02:00
LibretroAdmin
cd04f770b9 (MaterialUI) Don't keep assembling MaterialUI icons path - store it once
in materialui_init
2022-08-01 01:17:39 +02:00
LibretroAdmin
e9a6252fc7 (Ozone) Some simplifications - less string concatenation 2022-08-01 01:06:38 +02:00
LibretroAdmin
83a2ec1da8 (Ozone/XMB) Move some fill_pathname_join operations out of the loops since
the output string is not subject to change during iterations
2022-08-01 00:49:33 +02:00
GABO1423
3d69321c70
(msg_hash_us.h) Small touch up (#14246)
* Update msg_hash_us.h

* Update menu_displaylist.c

* Update msg_hash_us.h

* Update menu_displaylist.c
2022-07-29 17:41:26 +02:00
sonninnos
349ef1add2
(XMB) Dynamic wallpaper fixes: (#14247)
- 'Load Content' playlists
- Period in the playlist name
2022-07-29 17:40:11 +02:00
sonninnos
0c4bf5f2e3
(Ozone) Fix playlist thumbnail mouse hover after returning from QM (#14244) 2022-07-29 15:01:44 +02:00
LibretroAdmin
22bef5dc6b (Ozone) Remove unused arrays 2022-07-29 13:07:16 +02:00
LibretroAdmin
592f9384b0 Silence code analysis warnings by Xcode - unused variables - nothing
done with value set - etc
2022-07-29 08:29:43 +02:00
sonninnos
052cdce29b
(Ozone+XMB) Add playlist icons under 'Load Content' (#14243) 2022-07-29 07:12:01 +02:00
sonninnos
6c38efb0ee
Prevent playlist thumbnail cycle from showing duplicate images (#14238) 2022-07-28 23:55:47 +02:00
sonninnos
6c1de85add
(Ozone+XMB) Thumbnail fixes (#14210) 2022-07-28 19:21:59 +02:00
LibretroAdmin
ba752b6364 Fix regression #14229 - NULL termination for strings still necessary
when passed to string_list_join_concat
2022-07-27 15:15:33 +02:00
Cthulhu-throwaway
29f0ba2e71
(Network/Vita) Add net_ifinfo support (#14225) 2022-07-26 16:10:23 +01:00
libretroadmin
eb4440fafa Fix previous mistake in menu_action_sublabel_contentless_core 2022-07-26 13:45:41 +02:00
libretroadmin
88c2ae9ddf No null termination for strings passed to strlcpy/srlcat 2022-07-26 13:23:28 +02:00
Cthulhu-throwaway
8d4a64ab96
(Netplay) Disallow netplay start when content is not loaded for static core platforms (#14220) 2022-07-26 07:21:57 +02:00
libretroadmin
a6a4b845a4 Some string simplifications - don't NULL terminate if we pass
string to strlcpy and/or a file_path function using strlcpy under
the hood - don't do strlcpy for trivial setting of 2/3 char strings
2022-07-25 04:39:08 +02:00
TheRhysWyrill
54d0d84696
Fixed Purple Rain Theme (#14214)
* Add Purple Rain Theme
2022-07-25 00:44:31 +02:00
TheRhysWyrill
522d1ed16d
Add Purple Rain Theme (#14212)
* Add Purple Rain Theme

* Revert "Add Purple Rain Theme"

This reverts commit ceb896785b097d030d463f400d27b7f2146ac29a.

* Add Purple Rain Theme
2022-07-24 21:26:16 +02:00
libretroadmin
5c98caa7fd Don't NULL-terminate string if we pass it to strlcpy and/or a
file_path function that calls strlcpy under the hood
2022-07-24 06:22:35 +02:00
libretroadmin
34a18f64e8 Don't do NULL termination on string when we pass the string to
strlcpy and/or a file_path function that does strlcpy under the hood
2022-07-23 10:46:05 +02:00
libretroadmin
d2aeba0a92 Cleanup - remove NULL-termination since we pass fullname now to
strlcpy always at first
2022-07-22 02:25:49 +02:00
libretroadmin
6cfcd749e4 (menu_driver.c)
* Fix issue 14190
* Simplify code by removing unneeded code
2022-07-22 02:13:18 +02:00
sonninnos
1f244aac01
(Ozone+XMB) Thumbnail improvements (#14188) 2022-07-21 15:25:12 +02:00
libretroadmin
4b5c7856e6 Remove some more explicit NULL-termination when we're calling a
string function that calls strlcpy under the hood
2022-07-19 20:43:12 +02:00
LibretroAdmin
29774f5b7a
Small opts (#14186)
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop

* (input_driver.c) General cleanups:
* Some small code/style nits

task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c

(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on

General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
LibretroAdmin
87240556ea
Should fix Android strtol regression (when converting from sscanf) (#14183) 2022-07-18 04:38:52 +02:00
libretroadmin
fbd765f167 Change menu_setting.c back 2022-07-18 03:11:38 +02:00
libretroadmin
de6c077e4d (menu_cbs_get_value.c) Small nits 2022-07-17 19:23:46 +02:00
libretroadmin
66ea402de8 We already check if descriptor is empty beforehand 2022-07-17 19:15:37 +02:00
libretroadmin
a39532f19d (menu_cbs_get_value) Try to prevent assignments to string buffer if not needed 2022-07-17 18:59:21 +02:00
libretroadmin
08cccc811c Some slight optimizations of menu callback functions - better variable
scoping
2022-07-17 18:09:28 +02:00
libretroadmin
c3483654c9 Revert back to sscanf for versions of MSVC prior to MSVC2013 - prior
to MSVC2013, MSVC did not yet support strtof
2022-07-17 17:37:22 +02:00
libretroadmin
3ebfcbc7c7 setting_set_with_string_representation - avoid sscanf for trivial
operations when we can use strtol/strtoul/strtof
2022-07-17 09:46:27 +02:00
libretroadmin
e4b33fd0e6 (formats/json/rjson.c) Get rid of some implicit strlens and pass
size parameter to the functions instead˜
2022-07-17 06:58:22 +02:00
libretroadmin
b56b447f08 Fix these two memory errors that popped up with ASAN -
* Argument base for qsort cannot be NULL
* When system_count is 0 or less, early return out of explore_load_icons
2022-07-15 19:16:21 +02:00
libretroadmin
4b1766cf61 Silence more -Wdocumentation warnings 2022-07-15 01:12:04 +02:00
Cthulhu-throwaway
f5d46681c2
(UWP) Enable core downloader/updater (#14173) 2022-07-14 15:21:49 +02:00
libretroadmin
c4fb055fdb Cleanups:
* Combine early return and assignment lines
* use path_basename_nocompression when possible
* Move variables to proper scope
2022-07-12 20:44:00 +02:00