49 Commits

Author SHA1 Message Date
libretroadmin
69a2d124c0 Don't do NULL termination on string if we pass it off to strlcpy
and/or a file_path function that uses strlcpy under the hood
2022-07-24 05:39:51 +02:00
LibretroAdmin
29774f5b7a
Small opts (#14186)
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop

* (input_driver.c) General cleanups:
* Some small code/style nits

task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c

(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on

General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
libretroadmin
ad87f88b72 (task_pl_thumbnail_download.c) Minor cleanups/style nits - reducing
return paths
2022-07-09 17:13:26 +02:00
twinaphex
9bcee062ff Cleanups/warnings 2022-03-07 19:32:01 +01:00
twinaphex
7c8c53fb2d Get rid of menu_driver_get_ptr - we are going to be using only one
getter for each component state instead of several getters
2021-09-21 07:14:27 +02:00
twinaphex
544a17926b Use path_basename_nocompression where we are sure we are not
dealing with a filename with a compressed archive hash
2021-04-11 17:44:41 +02:00
twinaphex
ed6dd6d6d1 Fix get_thumbnail_paths 2021-03-29 17:42:32 +02:00
twinaphex
cc8160d044 task_pl_thumbnail_download.c - put char string of 8192 length
on heap for all platforms
2021-03-29 09:28:26 +02:00
Autechre
ba7900a3fb
Merge pull request #12173 from crystalct/master
Some PSL1GHT fixes
2021-03-29 09:26:24 +02:00
CrystalCT
b9ff6cb1d9 Some PSL1GHT fixes 2021-03-29 09:01:03 +02:00
Jamiras
501fe45a9f have http tasks clean up after themselves 2021-03-15 19:42:25 -06:00
twinaphex
4ec216dc0b Get rid of file_path_str 2020-08-22 01:06:10 +02:00
twinaphex
87c0fb6323 Struct reordering 2020-08-14 18:58:09 +02:00
twinaphex
d3b234f404 Buildfix 2020-08-11 09:03:59 +02:00
twinaphex
ac083e69ba Cleanups 2020-08-11 06:46:45 +02:00
twinaphex
d72b118a2d Make char array big enough 2020-07-23 05:21:32 +02:00
twinaphex
408f40f413 Cut down on some callocs 2020-06-27 16:36:08 +02:00
jdgleaver
0fcfb3deda Refactor playlist struct configuration 2020-06-26 15:40:19 +01:00
twinaphex
de36ff20fb Create string_ends_with_size 2020-06-25 14:38:06 +02:00
twinaphex
c31bfb4dc8 (task_pl_thumbnail_download) Simplifications 2020-06-08 21:20:07 +02:00
twinaphex
ce95dcaf79 (task_pl_thumbnail_download) Some string_is__equal optimizations 2020-06-08 07:31:58 +02:00
twinaphex
6cc47f8ee0 task_pl_thumbnail_download - replace many subsequent strlcat calls
with one snprintf
2020-05-29 10:30:56 +02:00
jdgleaver
955e25fc39 (On Demand Thumbnails) Fix heap-use-after-free error 2020-05-22 11:07:34 +01:00
twinaphex
38135c505b Rearrange struct members based on size 2020-03-12 06:59:07 +01:00
twinaphex
32e4aea068 Start making the other code safe that is dependent on menu driver
ident checking
2020-03-04 20:47:39 +01:00
twinaphex
0ef1b342e4 settings Cleanups 2020-03-02 20:10:24 +01:00
twinaphex
f74225721d menu_thumbnail and menu_thumbnail_path now decoupled from menu
system
2020-02-16 16:38:17 +01:00
twinaphex
cd20966fc8 Remove more settings_t dependencies 2020-02-03 08:00:08 +01:00
Jamiras
7325147d83 add task_push_http_transfer_file 2020-01-17 19:48:40 -07:00
jdgleaver
495ad41741 Thumbnail downloader clean-ups 2020-01-10 11:08:36 +00:00
jdgleaver
c356969c3a (GLUI) Add initial thumbnail support 2019-10-31 17:25:55 +00:00
twinaphex
b94b9e2adb Go back to plain strlcpy/strlcat - probably best to look at
opportunities to reduce these calls vs. replacing them with
unsafe macros
2019-09-23 00:19:01 +02:00
twinaphex
3b057d9605 Start using STRLCAT_CONST_INCR and STRLCPY_CONST 2019-09-20 23:33:17 +02:00
twinaphex
ec4bfd7827 Silence some warnings - statement unreachable etc. 2019-09-20 06:17:40 +02:00
twinaphex
db624a7c99 Start cleaning up the rather messy manual assignment 2019-09-20 02:03:26 +02:00
twinaphex
8fa6230426 Cleanups 2019-09-18 02:16:47 +02:00
twinaphex
d01ae6929d Don't use strlcat for basic concatenation of characters
except when absolutely necessary
2019-09-17 02:00:04 +02:00
jdgleaver
75ae05d287 (menu_thumbnail_path) API clean-up + tiny bug fix 2019-08-16 15:49:57 +01:00
twinaphex
c69c972942 (Menu) Cleanups 2019-08-16 15:17:33 +02:00
jdgleaver
5220dc9084 Add independent 'favourites' playlist size setting 2019-07-30 17:13:04 +01:00
jdgleaver
d6b2e83408 filestream_exists() -> path_is_valid() replacements 2019-05-30 12:19:52 +01:00
jdgleaver
ef459df761 (On-demand thumbnails) Prevent unnecessary 'menu refresh' events when rapidly scrolling/switching playlists 2019-05-27 15:49:34 +01:00
jdgleaver
20aff2a05a Add optional 'on demand' thumbnail downloads 2019-05-24 12:03:26 +01:00
twinaphex
ab8f0e73b7 Cleanups 2019-05-22 10:23:34 +02:00
twinaphex
5bcf8bebd0 (task_pl_thumbnail_download) Cleanups 2019-05-22 10:10:04 +02:00
jdgleaver
98889e1652 Ensure that displayed thumbnails are always refreshed correctly after selecting 'Download Thumbnails' from quick menu 2019-05-20 16:09:59 +01:00
jdgleaver
05c8694e1c Add 'Download Thumbnails' option to quick menu 2019-05-16 14:34:01 +01:00
jdgleaver
d04e3b6291 Attempt to fix build error: invalid conversion from ‘void*’ to ‘retro_task_t*’ 2019-05-14 17:34:17 +01:00
jdgleaver
154957505c Add playlist-based thumbnail downloader 2019-05-14 16:26:16 +01:00