75 Commits

Author SHA1 Message Date
libretroadmin
d514f1ded3 Avoid false positives with code analysis tools - rename
variables called 'system'
2023-07-05 03:29:49 +02:00
Eric Warmenhoven
280dcb32f9 Fix several warnings 2023-07-02 05:46:45 +02:00
libretroadmin
2cebb07201 (menu_explore) General cleanups:
* Use strlcpy instead of strlcat
* Some style nits
2023-06-20 14:42:31 +02:00
libretroadmin
fa80ec099f Rewrite some strlcat calls to strlcpy 2023-06-20 13:21:26 +02:00
libretroadmin
246cceeb27 Silence more signedness warnings 2023-06-14 19:51:31 +02:00
Grisly Glee
4202f8650d
Fix trivial signedness warnings (#15377)
* Fix trivial signedness warnings

* Followup on trivial signedness warnings
2023-06-14 04:43:11 +02:00
libretroadmin
c0ba738f0d Header uniformity - enums on top, then structs, then public declarations 2023-05-30 21:03:36 +02:00
libretroadmin
976d7b8067 Get rid of some useless wrapper functions 2023-05-28 17:56:28 +02:00
libretroadmin
3517091a1e (menu_explore.c) Cleanups 2023-05-24 01:52:04 +02:00
libretroadmin
c7a3581ee5 Bugfix for earlier commit 2023-05-24 01:03:08 +02:00
libretroadmin
4cc6ba8482 (Menu Explore) Small cleanups 2023-05-24 00:47:02 +02:00
libretroadmin
07cb5f4e98 Remove MENU_ENTRIES_CTL_SET_REFRESH 2023-05-11 01:58:30 +02:00
libretroadmin
6952f0709a Some simplifications 2023-05-10 19:13:46 +02:00
libretroadmin
0674613d28 Change return types of menu_driver_list_get_selection/get_size
and simplify struct
2023-05-10 08:36:44 +02:00
libretroadmin
9861073363 Get rid of menu_entries_get_menu_stack_ptr 2023-05-10 04:48:27 +02:00
libretroadmin
099f33e0b3 (Menu) Simplifications 2023-05-06 22:10:55 +02:00
libretroadmin
8a3686df58 Revert "Header cleanups - don't include retroarch.h everywhere"
This reverts commit 0e3b478f8c00b015aec9a78d13e73277500e5449.
2023-01-08 09:05:46 +01:00
libretroadmin
0e3b478f8c Header cleanups - don't include retroarch.h everywhere 2023-01-08 08:56:57 +01:00
reallibretroadmin
adee2dbe72 * Use strlcat instead of strcat
* Silence implicit conversion warnings detected in Xcode
2023-01-07 07:12:25 +01:00
sonninnos
d03b77d4cf
Menu icon improvements (#14679) 2022-11-27 19:19:55 +01:00
LibretroAdmin
320886f9fa Fix some function declarations 2022-10-17 19:56:32 +02:00
Bernhard Schelling
c9bbe7683f
Add View feature (#14467)
* Add View feature
Add saving of a filter set in the Explore menu into a so called "View" file which then gets listed alongside playlists.
This also adds the ability to filter a category by range in the Explore menu and not just filter on exact matches.

* Menu improvements for explore and views

* Collapse ozone sidebar in view

* Fix problems with the sidebar in explore/view

* Ignore view files in the Qt playlists menu

* Add missing semicolon

* Support downloading thumbnails in views
2022-10-10 06:36:02 +02:00
sonninnos
c4c55077a1
Allow On-Demand Thumbnails in Explore menu (#14385) 2022-09-05 00:01:38 +02:00
LibretroAdmin
003cea5d42 Fix some 'implicit conversion loses precision' warnings 2022-09-01 15:15:48 +02:00
LibretroAdmin
60030e373e
Reduce snprintfs + assorted cleanups (#14369)
* Reduce snprintf and/or use them only for concatenating the
string formatting of numbers/values
* Reduce snprintfs
* Use snprintf for concatenation at parts
* * We don't need to NULL-terminate strings that get passed to strlcpy/strlcat
and friends
* Use snprintf for concatenation in certain instances
* Do away with some string intermediary copies where we can avoid it
* Fix warning unused variable
* * Reduce snprintf calls
* Rewrite snprintf calls into strlcpy where possible
* Use snprintf for concatenation when necessary
* Do away with some string intermediary copies in task_translation.c
* run_translation_service - make switch slightly smaller
2022-09-01 04:17:07 +02:00
sonninnos
a96c5f77c8
(Ozone/XMB/RGUI) Explore menu thumbnails (#14365) 2022-08-31 14:42:10 +02:00
LibretroAdmin
f1ff92c881 * menu_entries_append and menu_entries_append_enum are now combined into
one - if you set the last parameter to a valid 'rarch_setting_t' pointer
and enum_msg to MSG_UNKNOWN, you will get the previous menu_entries_append
behavior
* Renamed remaining function to menu_entries_append so that we have one
consistent way of adding menu entries instead of two
Reduces some code duplication significantly
2022-08-27 17:40:52 +02:00
LibretroAdmin
c7786a45e1 Create path_get_extension_mutable and use it in menu_explore function
for trivial extension replacement in string
2022-08-06 19:06:31 +02:00
LibretroAdmin
b2634ea588 * Create fill_pathname_join_special - and specify fill_pathname_join
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00
libretroadmin
a6a4b845a4 Some string simplifications - don't NULL terminate if we pass
string to strlcpy and/or a file_path function using strlcpy under
the hood - don't do strlcpy for trivial setting of 2/3 char strings
2022-07-25 04:39:08 +02:00
libretroadmin
b56b447f08 Fix these two memory errors that popped up with ASAN -
* Argument base for qsort cannot be NULL
* When system_count is 0 or less, early return out of explore_load_icons
2022-07-15 19:16:21 +02:00
libretroadmin
d706c9c5bf Start deprecating trivial functions in file_path.c 2022-07-11 19:56:46 +02:00
libretroadmin
367dfd6e71 No longer include file_path_special.h in gfx_display.h 2022-06-26 18:35:07 +02:00
TheRetroPirate
6f90b24f72 added more categories to the explore menu 2022-03-15 05:51:20 +01:00
twinaphex
13d662d76b Silence some warnings 2021-11-11 22:28:16 +01:00
jdgleaver
c67c7c944d
Initialise 'Explore' menu on a background thread (#13162) 2021-10-27 17:51:22 +02:00
twinaphex
7c8c53fb2d Get rid of menu_driver_get_ptr - we are going to be using only one
getter for each component state instead of several getters
2021-09-21 07:14:27 +02:00
Bernhard Schelling
39275e8ce3
Fix CRC32 reading in explore
If CRC32 contained a zero byte strlen doesn't work
2021-08-03 23:38:37 +09:00
twinaphex
9f6a5e35de Get rid of more duplicate pointer grabbing 2021-04-08 02:02:30 +02:00
twinaphex
8b2eb8ed37 Cut down on config_get_ptr calls in menu_displaylist_ctl 2021-03-21 16:36:36 +01:00
jdgleaver
523e37ec95 Prevent segfault when accessing 'Explore' menu 2021-03-16 11:30:05 +00:00
Bernhard Schelling
9bea4831d7 Add 32-bit key hash map rhmap
Based on ex_hashmap32 in menu_explore.c, modify that to use the new rhmap
2021-01-03 00:52:25 +09:00
jdgleaver
0207fbf7b5 Explore Menu: Fix heap buffer overflow on initialisation 2020-10-05 10:15:54 +01:00
twinaphex
2e5bfd74ec Optimize explore_check_company_suffix 2020-09-27 23:56:15 +02:00
Bernhard Schelling
46bbbc4478
Order structs according to coding guidelines 2020-08-16 03:22:09 +09:00
twinaphex
023fd4f330 Alignment changes 2020-08-14 18:19:57 +02:00
Bernhard Schelling
398aa25c98
Zero icon list even on menu drivers without icons
Otherwise there is a chance for a crash on program exit on certain gfx drivers because it tries to free uninitialized texture ids.
2020-08-07 20:49:06 +09:00
Bernhard Schelling
0a67c0416a Change playlist to use dynamic array
Instead of initial 12MB memory allocation, use a dynamically growing array.
This shares the container structure (now called rbuf) with the explore menu.
2020-08-07 03:27:52 +09:00
Bernhard Schelling
a0db4db6c6
Instead of #if 0 use an explicit unused name 2020-08-05 01:46:32 +09:00
Bernhard Schelling
075c9162b7
Disable undocumented original_title field 2020-08-05 01:18:22 +09:00