756 Commits

Author SHA1 Message Date
Cthulhu-throwaway
690c802921
Netplay Stuff (#13375)
* Netplay Stuff

## PROTOCOL FALLBACK
In order to support older clients a protocol fallback system was introduced.
The host will no longer send its header automatically after a TCP connection is established, instead, it awaits for the client to send his before determining which protocol this connection is going to operate on.
Netplay has now two protocols, a low protocol and a high protocol; the low protocol is the minimum protocol it supports, while the high protocol is the highest protocol it can operate on.
To fully support older clients, a hack was necessary: sending the high protocol in the unused client's header salt field, while keeping the protocol field to the low protocol. Without this hack we would only be able to support older clients if a newer client was the host.
Any future system can make use of this system by checking connection->netplay_protocol, which is available for both the client and host.

## NETPLAY CHAT
Starting with protocol 6, netplay chat is available through the new NETPLAY_CMD_PLAYER_CHAT command.
Limitations of the command code, which causes a disconnection on unknown commands, makes this system not possible on protocol 5.
Protocol 5 connections can neither send nor receive chat, but other netplay operations are unaffected.
Clients send chat as a string to the server, and it's the server's sole responsability to relay chat messages.
As of now, sending chat uses RetroArch's input menu, while the display of on-screen chat uses a widget overlay and RetroArch's notifications as a fallback.
If a new overlay and/or input system is desired, no backwards compatibility changes need to be made.
Only clients in playing mode (as opposed to spectating mode) can send and receive chat.

## SETTINGS SHARING
Some settings are better used when both host and clients share the same configuration.
As of protocol 6, the following settings will be shared from host to clients (without altering a client's configuration file): input latency frames and allow pausing.

## NETPLAY TUNNEL/MITM
With the current MITM system being defunct (at least as of 1.9.X), a new system was in order to solve most if not all of the problems with the current system.
This new system uses a tunneling approach, which is similar to most VPN and tunneling services around.

Tunnel commands:
RATS[unique id] (RetroArch Tunnel Session) - 16 bytes -> When this command is sent with a zeroed unique id, the tunnel server interprets this as a netplay host wanting to create a new session, in this case, the same command is returned to the host, but now with its unique session id. When a client needs to connect to a host, this command is sent with the unique session id of the host, causing the tunnel server to send a RATL command to the host.
RATL[unique id] (RetroArch Tunnel Link) - 16 bytes -> The tunnel server sends this command to the host when a client wants to connect to the host. Once the host receives this command, it establishes a new connection to the tunnel server, sending this command together with the client's unique id through this new connection, causing the tunnel server to link this connection to the connection of the client.
RATP (RetroArch Tunnel Ping) - 4 bytes -> The tunnel server sends this command to verify that the host, whom the session belongs to, is still around. The host replies with the same command. A session is closed if the tunnel server can not verify that the host is alive.

Operations:
Host -> Instead of listening and accepting connections, it connects to the tunnel server, requests a new session and then monitor this connection for new linking requests. Once a request is received, it establishes a new connection to the tunnel server for linking with a client. The tunnel server's address and port are obtained by querying the lobby server. The host will publish its session id together with the rest of its info to the lobby server.
Client -> It connects to the tunnel server and then sends the session id of the host it wants to connect to. A host's session id is obtained from the json data sent by the lobby server.

Improvements (from current MITM system):
No longer a risk of TCP port exhaustion; we only use one port now at the tunnel server.
Very little cpu usage. About 95% net I/O bound now.
Future backwards compatible with any and all changes to netplay as it no longer runs any netplay logic at MITM servers.
No longer operates the host in client mode, which was a source of many of the current problems.
Cleaner and more maintainable system and code.

Notable functions:
netplay_mitm_query -> Grabs the tunnel's address and port from the lobby server.
init_tcp_socket -> Handles the creation and operation mode of the TCP socket based on whether it's host, host+MITM or client.
handle_mitm_connection -> Creates and completes linking connections and replies to ping commands (only 1 of each per call to not affect performance).

## MISC
Ping Limiter: If a client's estimated latency to the server is higher than this value, connection will be dropped just before finishing the netplay handshake.
Ping Counter: A ping counter (similar to the FPS one) can be shown in the bottom right corner of the screen, if you are connected to a host.
LAN Discovery: Refactored and moved to its own "Refresh Netplay LAN List" button.

## FIXES
Many minor fixes to the current netplay implementation are also included.

* Remove NETPLAY_TEST_BUILD
2021-12-19 16:58:01 +01:00
Tomáš Kelemen (vudiq)
efad7a7dcc
Lakka: CD-ROM eject menu item
Adds new entry (where the entry for dumping CD is) to eject the disc -
in case the CD drive has no physical button to eject the disc / the
button does not work. Useless for most, but quality of life improvement
for some.

Upstream of patch used by Lakka at build time
1943ad296e/packages/libretro/retroarch/patches/retroarch-99-eject_disc.patch
2021-11-18 00:36:01 +01:00
twinaphex
13d662d76b Silence some warnings 2021-11-11 22:28:16 +01:00
twinaphex
fde3406d1b Get rid of input_event_get_osk_ptr/get_osk_grid 2021-10-01 07:37:33 +02:00
twinaphex
e886e908d5 Create consistent naming conventions - use retroarch_ instead
of rarch_ for some functions for all functions coming from retroarch.h
2021-09-28 12:56:10 +02:00
twinaphex
83ce4259a0 Have only one getter for runloop_state 2021-09-21 19:08:26 +02:00
twinaphex
295aa84a9e Cleanups 2021-09-20 20:43:05 +02:00
twinaphex
5e4ce74000 Get rid of duplicate code in gfx_widgets -
gfx_display_get_widget_dpi_scale made redundant
2021-09-13 20:21:36 +02:00
twinaphex
490233f3c5 wite_texture is now a static global variable inside gfx_display.c
- no longer referenced outside
2021-09-13 19:55:53 +02:00
twinaphex
fc4d4c53cd Cleanup some references to gfx_display_white_texture and
don't assume NULL == 0 for uintptr_t
2021-09-13 19:07:09 +02:00
jdgleaver
6da778b934 (Playlist Manager) Add 'Refresh Playlist' option 2021-09-09 16:18:26 +01:00
Autechre
36888612eb
Reduce gfx_display_rotate_z calls in menu drivers (#12937)
* (Ozone) Take out gfx_display_rotate_z out of ozone_draw_icon -
lots of matrix rotates and multiplies were happening when
just calling it once would suffice

* (MaterialUI) Reduce calls to gfx_display_rotate_z

* (XMB) Cleanup
2021-09-05 03:46:52 +02:00
jdgleaver
508b0c2ee2 Add enhanced search functionality to the 'Cheats' menu 2021-09-03 14:58:33 +01:00
Autechre
7b9cbc08d7
Add HDR support for D3D12 (rebased PR from MajorPainTheCactus) (#12917)
* Add HDR support

* Attempt to fix Mingw build and Metal builds

* (D3D12) Fix relative header includes

* Add missing hdr_sm5.hlsl.h

* (d3d12_common.c) Some C89 build fixes

* Fix MSVC build

* - Attempt to fix build on mingw/msys unix with dirty hack
- Fix shader compilation of hdr_sm5.hlsl.h on MSVC/Visual Studio -
the define was seen as an error and was causing the first pipeline
to error out
- Make sure we manually set handle of backBuffer to NULL

* Moving the release of the texture above the freeing of desc.srv_heap
and desc.rtv_heap solves the hard crashes on teardown/setup in RA -
it was crashing hard in d3d12_release_texture before

* Add HAVE_D3D12_HDR ifdef - needs to be disabled for WinRT for now
because of several things that are Windows desktop-specific right now
(GetWindowRect)

* Add dirty GUID hack - should work for both mingw/msys on Windows/Linux
as well as MSVC/Visual Studio (hopefully)

* Change HAVE_D3D12_HDR to HAVE_DXGI_HDR

* Move away from camelcase named variables

* Fix RARCH_ERR logs - they need a newline at the end

* d3d12_check_display_hdr_support - make it return a bool on return
and set d3d12->hdr.support and d3d12->hdr.enable outside of the
function

* (DXGI) Remove D3D12 dependencies from dxgi_check_display_hdr_support and
move it to dxgi_common.c instead

* (DXGI) move d3d12_swapchain_color_space over to dxgi_common.c and
rename it dxgi_swapchain_color_space

* (DXGI) move d3d12_set_hdr_metadata to dxgi_common.c and
rename it dxgi_set_hdr_metadata

* (DXGI) dxgi_check_display_hdr_support - better error handling?

* Fix typo

* Remove video_force_resolution

* (D3D12) Address TODO/FIXME

* (D3D12) Backport
c1b6c0bff2
- Fixed resource transition for present when HDR is off
Fixed cel shader displaying all black as blending was enabled when the hdr shader was being applied - turned off blending during this shader

* Move d3d12_hdr_uniform_t to dxgi_common.h and
rename it dxgi_hdr_uniform_t

* (D3D11) Add HDR support

* Add TODO/FIXME notes

* Cache hdr_enable in video_frame_info_t

* Update comment
2021-09-03 06:15:25 +02:00
jdgleaver
a6901dc85e Add option to (force-)write current core options to disk 2021-08-26 11:42:46 +01:00
twinaphex
bea512b70b Get rid of gfx_display_draw_texture - use gfx_display_draw_quad instead 2021-08-22 17:57:21 +02:00
jdgleaver
7a3d78b1c0 (Menu+Widgets) Add workaround for FPU bug that breaks scale factor comparisons on certain platforms (fixes XMB thumbnails on 32bit Linux/Windows) 2021-07-12 12:14:55 +01:00
jdgleaver
3c2e3f1ce9
Add enhanced search functionality to the 'Manage Cores' menu (#12516) 2021-06-11 21:17:32 +02:00
toshixm
4fab84ca9e improve message wrapping with CJK languages 2021-06-03 21:09:35 +09:00
twinaphex
0482892a9c Get rid of return variable for snprintf 2021-05-18 23:09:45 +02:00
jdgleaver
f4511f6fa4 (core_info) Performance optimisations + code clean-ups/refactors 2021-04-26 14:30:31 +01:00
jdgleaver
80753ac741 Add search filter support to cheats and overlays file browser menus 2021-04-22 16:56:57 +01:00
jdgleaver
a6cffc0e29 (XMB/GLUI/Ozone) Add optional menu screensaver animations 2021-04-13 15:36:57 +01:00
twinaphex
544a17926b Use path_basename_nocompression where we are sure we are not
dealing with a filename with a compressed archive hash
2021-04-11 17:44:41 +02:00
twinaphex
5334ddd199 Don't call anim_get_ptr inside gfx_thumbnail.c 2021-04-08 01:30:42 +02:00
jdgleaver
371d0b7395 Add optional menu screensaver 2021-04-01 17:26:43 +01:00
jdgleaver
6d13ace83a (GLUI) Add icon to 'Turbo Fire' menu entry 2021-03-29 15:50:32 +01:00
twinaphex
cd9d6c0511 gfx_display - Get rid of lots of pointer grabbing 2021-03-25 20:12:34 +01:00
twinaphex
8064af8f15 Get rid of more pointer grabbing 2021-03-25 19:22:12 +01:00
twinaphex
78e9a16493 Cut down on disp_get_ptr calls 2021-03-21 15:37:40 +01:00
twinaphex
a0a681b324 (Menu drivers) Less pointer grabbing - cut down on get_ptr calls 2021-03-20 17:45:05 +01:00
jdgleaver
235967c606 GLUI: Fix main menu 'History' entry 2021-03-16 10:10:37 +00:00
twinaphex
b8c51ed040 Remove unused variables 2021-03-15 09:32:47 +01:00
twinaphex
4e883c4568 Refactor menu_displaylist_setting away 2021-03-15 06:11:57 +01:00
twinaphex
14248f7401 (Menu) Iterate function callback was never used, remove it
- Also turn menu_driver_iterate into static function and
redesign code a bit; non-functional
2021-03-11 20:17:22 +01:00
twinaphex
e5045fa2e2 Simplify menu_driver_deferred_push_content_list 2021-03-11 03:49:51 +01:00
twinaphex
839a270a97 Menu refactors:
- Get rid of menu_driver_search_list_clear
- Get rid of contentlist_switch callback - was only ever one
function callback implementation
2021-03-11 03:37:19 +01:00
twinaphex
db314cf5df file_list_set_userdata / file_list_set_actiondata are trivial one-line
functions - just set it directly
2021-03-07 19:30:04 +01:00
jdgleaver
20a187ef9c Add option to reset all core options for current core/content 2021-02-25 16:59:05 +00:00
jdgleaver
110e318b71 Add support for saving per-directory core options and deleting core option overrides 2021-02-25 10:54:22 +00:00
twinaphex
1a9f1f6b33 gfx_display_init_first_driver was called twice, once invoked by
drivers_init, after that invoked by each menu driver's init function.
Taking the extra function call out of the menu driver's init function
2021-02-22 06:38:55 +01:00
Autechre
f661cc3fb5
Merge pull request #11572 from ImJezze/master
Option to open the file browser in the last used directory
2021-02-08 12:29:31 +01:00
ImJezze
270c41b35a Implement toggle to open the start directory at the last used location 2021-02-07 11:54:17 +01:00
twinaphex
4df6d287e3 (Clang) Silence 'n' is never used warnings 2021-02-03 11:48:33 +01:00
twinaphex
542162c17b Silence some warnings 2021-02-03 10:39:29 +01:00
twinaphex
9a4472266f Try to avoid hot function file_list_get_userdata_at_offset 2021-01-19 07:52:13 +01:00
jdgleaver
b1ee5a2421 (X11) Fix mouse input when mouse is grabbed 2021-01-16 13:57:25 +00:00
Ömercan Kömür
6256b8ca2b first 2020-12-19 15:14:14 +03:00
jdgleaver
a02fadeb94 Add 'Remove DSP Plugin' menu entry 2020-10-19 11:33:15 +01:00
twinaphex
5f8c270d4c Make update_time_callback a part of the animation struct 2020-10-15 08:35:37 +02:00