mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-02-25 03:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Validate non-causal filter chain for texture inputs.

Browse Source 
We only validated for UBO inputs apparently.
This commit is contained in:
Themaister 2019-08-13 13:55:10 +02:00
parent 17d2ce5220
commit f957bf0d16
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gfx/drivers_shader/slang_reflection.cpp
View File

@ -349,7 +349,7 @@ static bool add_active_buffer_ranges(
if (tex_sem == SLANG_TEXTURE_SEMANTIC_PASS_OUTPUT && tex_sem_index >= reflection->pass_number) if (tex_sem == SLANG_TEXTURE_SEMANTIC_PASS_OUTPUT && tex_sem_index >= reflection->pass_number)
{ {
RARCH_ERR("[slang]: Non causal filter chain detected." RARCH_ERR("[slang]: Non causal filter chain detected. "
"Shader is trying to use output from pass #%u," "Shader is trying to use output from pass #%u,"
" but this shader is pass #%u.\n", " but this shader is pass #%u.\n",
tex_sem_index, reflection->pass_number); tex_sem_index, reflection->pass_number);
@ -637,7 +637,15 @@ bool slang_reflect(
*reflection->texture_semantic_map, *reflection->texture_semantic_map,
fragment.sampled_images[i].name, &array_index); fragment.sampled_images[i].name, &array_index);
if (index == SLANG_INVALID_TEXTURE_SEMANTIC) if (index == SLANG_TEXTURE_SEMANTIC_PASS_OUTPUT && array_index >= reflection->pass_number)
{
RARCH_ERR("[slang]: Non causal filter chain detected. "
"Shader is trying to use output from pass #%u,"
" but this shader is pass #%u.\n",
array_index, reflection->pass_number);
return false;
}
else if (index == SLANG_INVALID_TEXTURE_SEMANTIC)
{ {
RARCH_ERR("[slang]: Non-semantic textures not supported yet.\n"); RARCH_ERR("[slang]: Non-semantic textures not supported yet.\n");
return false; return false;