mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-30 07:20:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix leaks - we were not honoring the ownership policy/create rule

Browse Source 
for various CoreFoundation functions with 'Copy' or 'Create' in the title
This commit is contained in:
twinaphex 2021-08-07 03:46:08 +02:00
parent c1ed271a12
commit f459472f6d
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/drivers/platform_darwin.m
View File

@ -156,8 +156,13 @@ static void CFSearchPathForDirectoriesInDomains(unsigned flags,
CFArrayRef array = array_val ? CFRetain(array_val) : NULL;
CFTypeRef path_val = (CFTypeRef)CFArrayGetValueAtIndex(array, 0);
CFStringRef path = path_val ? CFRetain(path_val) : NULL;
CFRelease(array_val);
if (!path || !array)
{
if (path)
CFRelease(path);
return;
}
CFStringGetCString(path, s, len, kCFStringEncodingUTF8);
CFRelease(path);
@ -370,10 +375,13 @@ static void frontend_darwin_get_env(int *argc, char *argv[],
resource_url = CFBundleCopyResourcesDirectoryURL(bundle);
resource_path = CFURLCopyPath(resource_url);
CFRelease(resource_url);
CFStringGetCString(bundle_path,
bundle_path_buf, sizeof(bundle_path_buf), kCFStringEncodingUTF8);
CFStringGetCString(resource_path,
resource_path_buf, sizeof(resource_path_buf), kCFStringEncodingUTF8);
CFRelease(resource_path);
fill_pathname_join(full_resource_path_buf, bundle_path_buf, resource_path_buf, sizeof(full_resource_path_buf));
CFSearchPathForDirectoriesInDomains(CFDocumentDirectory,
CFUserDomainMask, 1, home_dir_buf, sizeof(home_dir_buf));

1
input/drivers_hid/iohidmanager_hid.c
View File

@ -1010,6 +1010,7 @@ static int iohidmanager_hid_manager_set_device_matching(
CFIndex num_devices = CFSetGetCount(set);
IOHIDDeviceRef *device_array = (IOHIDDeviceRef*)calloc(num_devices, sizeof(IOHIDDeviceRef));
CFSetGetValues(set, (const void **) device_array);
CFRelease(set);
/* re order device by location id */
typedef struct hid_list