mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-29 22:20:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

(task_database.c) Optimizations:

Browse Source 
- strlen was being called on path for each loop iteration, when
path is not subject to change - do it once outside
- String copying was being performed even when the string would
equal a string not subject to change
This commit is contained in:
twinaphex 2021-03-22 19:24:14 +01:00
parent 32a6bd021c
commit f22b077887
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tasks/task_database.c
View File

@ -643,27 +643,26 @@ static int database_info_list_iterate_end_no_match(
if (archive_list && archive_list->size > 0)
{
unsigned i;
size_t path_len = strlen(path);
for (i = 0; i < archive_list->size; i++)
{
char new_path[PATH_MAX_LENGTH];
size_t path_len = strlen(path);
new_path[0] = '\0';
strlcpy(new_path, path, sizeof(new_path));
if (path_len + strlen(archive_list->elems[i].data)
+ 1 < PATH_MAX_LENGTH)
{
char new_path[PATH_MAX_LENGTH];
new_path[0] = '\0';
strlcpy(new_path, path, sizeof(new_path));
new_path[path_len] = '#';
strlcpy(new_path + path_len + 1,
archive_list->elems[i].data,
sizeof(new_path) - path_len);
archive_list->elems[i].data,
sizeof(new_path) - path_len);
string_list_append(db->list, new_path,
archive_list->elems[i].attr);
}
string_list_append(db->list, new_path,
archive_list->elems[i].attr);
else
string_list_append(db->list, path,
archive_list->elems[i].attr);
}
string_list_free(archive_list);