mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-01-30 21:32:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix reading past the end of an allocated buffer. (#15713)

Browse Source 
title_length is originally calculated to be the msg length, but later
if the task has a title then that is used instead, but the length is
not updated. If msg is longer than title, we read past the end of the
buffer.
This commit is contained in:
Eric Warmenhoven 2023-09-20 13:50:35 -04:00 committed by GitHub
parent f33f5e2b87
commit ef12e43522
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gfx/gfx_widgets.c
View File

@ -243,6 +243,7 @@ void gfx_widgets_msg_queue_push(
{
title = msg_widget->msg = strdup(task->title);
msg_widget->msg_new = strdup(title);
title_length = strlen(title);
msg_widget->msg_len = title_length;
if (!string_is_empty(task->error))