mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-07 13:23:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

shader_parse: Fix potential sscanf buffer overflow

Browse Source 
Indexes are zero-based, so although the buffers are 64 elements in size, we only have addressing from 0-63.
This commit is contained in:
Lioncash 2014-09-04 01:51:51 -04:00
parent c5ebf22bfc
commit eb27dd4043
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gfx/shader_parse.c
View File

@ -304,7 +304,7 @@ bool gfx_shader_resolve_parameters(config_file_t *conf, struct gfx_shader *shade
while (shader->num_parameters < ARRAY_SIZE(shader->parameters) && fgets(line, sizeof(line), file)) while (shader->num_parameters < ARRAY_SIZE(shader->parameters) && fgets(line, sizeof(line), file))
{ {
int ret = sscanf(line, "#pragma parameter %64s \"%64[^\"]\" %f %f %f %f", int ret = sscanf(line, "#pragma parameter %63s \"%63[^\"]\" %f %f %f %f",
param->id, param->desc, &param->initial, &param->minimum, &param->maximum, &param->step); param->id, param->desc, &param->initial, &param->minimum, &param->maximum, &param->step);
if (ret >= 5) if (ret >= 5)