mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-10 06:44:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

allow callback to look at response BODY even when HTTP status code indicates failure (#15532)

Browse Source
This commit is contained in:
Jamiras 2023-07-28 20:59:44 -06:00 committed by GitHub
parent 62e6439329
commit e1c366317a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tasks/task_http.c
View File

@ -181,29 +181,16 @@ task_finished:
if (tmp && http->cb) if (tmp && http->cb)
http->cb(tmp, len); http->cb(tmp, len);
if (net_http_error(http->handle) || task_get_cancelled(task)) if (!tmp)
{
tmp = (char*)net_http_data(http->handle, &len, true); tmp = (char*)net_http_data(http->handle, &len, true);
if (task_get_cancelled(task))
{
if (tmp) if (tmp)
free(tmp); free(tmp);
if (task_get_cancelled(task)) task_set_error(task,
task_set_error(task, strldup("Task cancelled.", sizeof("Task cancelled.")));
strldup("Task cancelled.", sizeof("Task cancelled.")));
else
{
data = (http_transfer_data_t*)malloc(sizeof(*data));
data->data = NULL;
data->len = 0;
data->status = net_http_status(http->handle);
task_set_data(task, data);
if (!task->mute)
task_set_error(task, strldup("Download failed.",
sizeof("Download failed.")));
}
} }
else else
{ {
@ -213,6 +200,10 @@ task_finished:
data->status = net_http_status(http->handle); data->status = net_http_status(http->handle);
task_set_data(task, data); task_set_data(task, data);
if (!task->mute && net_http_error(http->handle))
task_set_error(task, strldup("Download failed.",
sizeof("Download failed.")));
} }
net_http_delete(http->handle); net_http_delete(http->handle);