Don't include errno.h in files that don't justify its use

file_path_special.c

@@ -45,7 +45,6 @@
 #include <boolean.h>
 #include <string.h>
 #include <time.h>
-#include <errno.h>
 
 #include <file/file_path.h>
 #include <string/stdstring.h>

frontend/drivers/platform_ctr.c

@@ -20,7 +20,6 @@
 #include <ctype.h>
 #include <boolean.h>
 #include <sys/stat.h>
-#include <errno.h>
 #include <dirent.h>
 
 #include <3ds.h>

frontend/drivers/platform_switch.c

@@ -20,7 +20,6 @@
 #include <ctype.h>
 #include <boolean.h>
 #include <sys/stat.h>
-#include <errno.h>
 #include <dirent.h>
 
 #include <file/nbio.h>

frontend/drivers/platform_win32.c

@@ -23,7 +23,6 @@
 #include <windows.h>
 #if defined(_WIN32) && !defined(_XBOX)
 #include <process.h>
-#include <errno.h>
 #endif
 
 #include <boolean.h>

gfx/common/wayland_common.c

@@ -368,18 +368,17 @@ static shm_buffer_t *create_shm_buffer(gfx_ctx_wayland_data_t *wl, int width,
    if (size <= 0)
       return NULL;
 
-   fd = create_shm_file(size);
-   if (fd < 0)
+   if ((fd = create_shm_file(size)) < 0)
    {
-      RARCH_ERR("[Wayland] [SHM]: Creating a buffer file for %d B failed: %s\n",
-         size, strerror(errno));
+      RARCH_ERR("[Wayland] [SHM]: Creating a buffer file for %d B failed\n",
+         size);
       return NULL;
    }
 
    data = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
    if (data == MAP_FAILED)
    {
-      RARCH_ERR("[Wayland] [SHM]: mmap failed: %s\n", strerror(errno));
+      RARCH_ERR("[Wayland] [SHM]: mmap failed\n");
       close(fd);
       return NULL;
    }

gfx/drivers/drm_gfx.c

@@ -22,7 +22,6 @@
 #include <libdrm/drm_fourcc.h>
 #include <fcntl.h>
 #include <sys/mman.h>
-#include <errno.h>
 
 #include <compat/strl.h>
 #include <rthreads/rthreads.h>
@@ -277,7 +276,6 @@ static void drm_page_flip(struct drm_surface *surface)
    /* We alredy have the id of the FB_ID property of
     * the plane on which we are going to do a pageflip:
     * we got it back in drm_plane_setup()  */
-   int ret;
    static drmModeAtomicReqPtr req = NULL;
 
    req = drmModeAtomicAlloc();
@@ -285,12 +283,10 @@ static void drm_page_flip(struct drm_surface *surface)
    /* We add the buffer to the plane properties we want to
     * set on an atomically, in a single step.
     * We pass the plane id, the property id and the new fb id. */
-   ret = drmModeAtomicAddProperty(req,
+   if (drmModeAtomicAddProperty(req,
          drm.plane_id,
          drm.plane_fb_prop_id,
-         surface->pages[surface->flip_page].buf.fb_id);
-
-   if (ret < 0)
+         surface->pages[surface->flip_page].buf.fb_id) < 0)
    {
       RARCH_ERR ("DRM: failed to add atomic property for pageflip\n");
    }
@@ -301,11 +297,9 @@ static void drm_page_flip(struct drm_surface *surface)
     * pageflip is complete. If you don't want -12 errors
     * (ENOMEM), namely "Cannot allocate memory", then
     * you must drain the event queue of that fd. */
-   ret = drmModeAtomicCommit(drm.fd, req, 0, NULL);
-
-   if (ret < 0)
+   if (drmModeAtomicCommit(drm.fd, req, 0, NULL) < 0)
    {
-      RARCH_ERR ("DRM: failed to commit for pageflip: %s\n", strerror(errno));
+      RARCH_ERR ("DRM: failed to commit for pageflip\n");
    }
 
    surface->flip_page = !(surface->flip_page);
@@ -543,7 +537,7 @@ static void drm_plane_setup(struct drm_surface *surface)
             plane_flags, plane_x, plane_y, plane_w, plane_h,
             src_x<<16, src_y<<16, src_w<<16, src_h<<16))
    {
-      RARCH_ERR("[DRM]: failed to enable plane: %s\n", strerror(errno));
+      RARCH_ERR("[DRM]: failed to enable plane\n");
    }
 
    RARCH_LOG("[DRM]: src_w %d, src_h %d, plane_w %d, plane_h %d\n",
@@ -604,9 +598,8 @@ static int modeset_create_dumbfb(int fd, struct modeset_buf *buf,
 
 static bool init_drm(void)
 {
-   int ret;
-   drmModeConnector *connector;
    uint i;
+   drmModeConnector *connector;
 
    drm.fd = open("/dev/dri/card0", O_RDWR);
 
@@ -619,18 +612,16 @@ static bool init_drm(void)
    /* Programmer!! Save your sanity!!
     * VERY important or we won't get all the available planes on drmGetPlaneResources()!
     * We also need to enable the ATOMIC cap to see the atomic properties in objects!! */
-   ret = drmSetClientCap(drm.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
-   if (ret)
+   if (drmSetClientCap(drm.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1))
       RARCH_ERR ("DRM: can't set UNIVERSAL PLANES cap.\n");
    else
       RARCH_LOG ("DRM: UNIVERSAL PLANES cap set\n");
 
-   ret = drmSetClientCap(drm.fd, DRM_CLIENT_CAP_ATOMIC, 1);
-   if (ret)
+   if (drmSetClientCap(drm.fd, DRM_CLIENT_CAP_ATOMIC, 1))
    {
       /*If this happens, check kernel support and kernel parameters
        * (add i915.nuclear_pageflip=y to the kernel boot line for example) */
-      RARCH_ERR ("DRM: can't set ATOMIC caps: %s\n", strerror(errno));
+      RARCH_ERR ("DRM: can't set ATOMIC caps\n");
    }
    else
       RARCH_LOG ("DRM: ATOMIC caps set\n");
@@ -688,8 +679,7 @@ static bool init_drm(void)
    struct modeset_buf buf;
    buf.width = drm.current_mode->hdisplay;
    buf.height = drm.current_mode->vdisplay;
-   ret = modeset_create_dumbfb(drm.fd, &buf, 4, DRM_FORMAT_XRGB8888);
-   if (ret)
+   if (modeset_create_dumbfb(drm.fd, &buf, 4, DRM_FORMAT_XRGB8888))
    {
       RARCH_ERR ("DRM: can't create dumb fb\n");
    }
@@ -742,10 +732,8 @@ static void *drm_gfx_init(const video_info_t *video,
       free(_drmvars);
       return NULL;
    }
-   else
-   {
-      RARCH_LOG ("DRM: Init successful.\n");
-   }
+
+   RARCH_LOG ("DRM: Init successful.\n");
 
    _drmvars->kms_width  = drm.current_mode->hdisplay;
    _drmvars->kms_height = drm.current_mode->vdisplay;

gfx/drivers_context/drm_ctx.c

@@ -19,7 +19,6 @@
  */
 
 #include <stdint.h>
-#include <errno.h>
 #include <string.h>
 #include <unistd.h>
 #include <math.h>
@@ -198,7 +197,7 @@ static struct drm_fb *drm_fb_get_from_bo(struct gbm_bo *bo)
    return fb;
 
 error:
-   RARCH_ERR("[KMS]: Failed to create FB: %s\n", strerror(errno));
+   RARCH_ERR("[KMS]: Failed to create FB.\n");
    free(fb);
    return NULL;
 }

gfx/drivers_context/drm_go2_ctx.c

@@ -19,7 +19,6 @@
  */
 
 #include <stdint.h>
-#include <errno.h>
 #include <string.h>
 #include <unistd.h>
 #include <math.h>

gfx/drivers_context/vc_egl_ctx.c

@@ -16,7 +16,6 @@
  */
 
 #include <stdint.h>
-#include <errno.h>
 #include <signal.h>
 #include <unistd.h>
 

input/drivers/wayland_input.c

@@ -21,7 +21,6 @@
 #include <unistd.h>
 
 #include <limits.h>
-#include <errno.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 

input/drivers_joypad/mfi_joypad.m

@@ -17,7 +17,6 @@
 #include <unistd.h>
 #include <string.h>
 #include <limits.h>
-#include <errno.h>
 
 #include <boolean.h>
 

input/drivers_joypad/parport_joypad.c

@@ -18,7 +18,6 @@
 #include <unistd.h>
 #include <limits.h>
 #include <stdio.h>
-#include <errno.h>
 
 #include <linux/parport.h>
 #include <linux/ppdev.h>

input/drivers_joypad/udev_joypad.c

@@ -19,7 +19,6 @@
 #include <string.h>
 #include <limits.h>
 #include <fcntl.h>
-#include <errno.h>
 
 #include <sys/types.h>
 #include <sys/stat.h>

libretro-common/file/file_path.c

@@ -24,7 +24,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
-#include <errno.h>
 
 #include <sys/stat.h>
 

libretro-common/file/file_path_io.c

@@ -24,7 +24,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
-#include <errno.h>
 
 #include <sys/stat.h>
 

libretro-common/formats/image_transfer.c

@@ -22,7 +22,8 @@
 
 #include <stdint.h>
 #include <string.h>
-#include <errno.h>
+
+#include <boolean.h>
 
 #ifdef HAVE_RPNG
 #include <formats/rpng.h>

libretro-common/streams/file_stream.c

@@ -25,7 +25,6 @@
 #include <string.h>
 #include <stdarg.h>
 #include <ctype.h>
-#include <errno.h>
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"

retroarch.c

@@ -55,7 +55,6 @@
 #include <stdint.h>
 #include <string.h>
 #include <ctype.h>
-#include <errno.h>
 #include <math.h>
 #include <locale.h>
 

runloop.c

@@ -57,7 +57,6 @@
 #include <stdint.h>
 #include <string.h>
 #include <ctype.h>
-#include <errno.h>
 #include <math.h>
 #include <locale.h>
 

tasks/task_bluetooth.c

@@ -13,7 +13,6 @@
  */
 
 #include <string.h>
-#include <errno.h>
 #include <compat/strl.h>
 #include <retro_assert.h>
 #include <retro_miscellaneous.h>

tasks/task_content_disc.c

@@ -20,7 +20,6 @@
 #include <sys/types.h>
 #include <string.h>
 #include <time.h>
-#include <errno.h>
 
 #include <file/file_path.h>
 #include <queues/task_queue.h>

tasks/task_file_transfer.c

@@ -14,7 +14,6 @@
  */
 
 #include <string.h>
-#include <errno.h>
 #include <file/nbio.h>
 #include <compat/strl.h>
 #include <retro_miscellaneous.h>

tasks/task_image.c

@@ -16,7 +16,6 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
-#include <errno.h>
 
 #include <file/nbio.h>
 #include <formats/image.h>

tasks/task_save.c

@@ -24,7 +24,6 @@
 #else
 #include <unistd.h>
 #endif
-#include <errno.h>
 
 #include <compat/strl.h>
 #include <retro_assert.h>

tasks/task_wifi.c

@@ -14,7 +14,6 @@
  */
 
 #include <string.h>
-#include <errno.h>
 #include <compat/strl.h>
 #include <retro_assert.h>
 #include <retro_miscellaneous.h>