(steam) Thread safety and style fixes (#13739)

This commit is contained in:
Mats 2022-03-13 18:14:20 +01:00 committed by GitHub
parent c1216fd16d
commit d675276e28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 44 deletions

View File

@ -60,8 +60,8 @@ void steam_poll(void)
{
/* Reload core info and Steam Core DLC mappings */
case MistCallback_DlcInstalled:
steam_get_core_dlcs(&core_dlc_list, true);
command_event(CMD_EVENT_CORE_INFO_INIT, NULL);
steam_get_core_dlcs(&core_dlc_list, false);
break;
}
@ -162,7 +162,8 @@ MistResult steam_generate_core_dlcs_list(steam_core_dlc_list_t **list)
MistResult result;
int count;
steam_core_dlc_list_t *dlc_list = NULL;
MistDlcData dlc_data;
char dlc_name[PATH_MAX_LENGTH] = { 0 };
bool avaliable;
result = mist_steam_apps_get_dlc_count(&count);
if (MIST_IS_ERROR(result)) goto error;
@ -172,16 +173,14 @@ MistResult steam_generate_core_dlcs_list(steam_core_dlc_list_t **list)
{
steam_core_dlc_t core_dlc;
result = mist_steam_apps_get_dlc_data_by_index(i, &dlc_data);
result = mist_steam_apps_get_dlc_data_by_index(i, &core_dlc.app_id, &avaliable, (char*)&dlc_name, PATH_MAX_LENGTH);
if (MIST_IS_ERROR(result)) goto error;
core_dlc.app_id = dlc_data.app_id;
/* Strip away the "RetroArch - " prefix if present */
if (strncmp(dlc_data.name, "RetroArch - ", sizeof("RetroArch - ") - 1) == 0)
core_dlc.name = strdup(dlc_data.name + sizeof("RetroArch - ") - 1);
if (strncmp(dlc_name, "RetroArch - ", sizeof("RetroArch - ") - 1) == 0)
core_dlc.name = strdup(dlc_name + sizeof("RetroArch - ") - 1);
else
core_dlc.name = strdup(dlc_data.name);
core_dlc.name = strdup(dlc_name);
/* Make a lower case version */
core_dlc.name_lower = strdup(core_dlc.name);

View File

@ -57,10 +57,6 @@ task_finished:
/* If finished successfully */
if(MIST_IS_SUCCESS(result))
{
/* Invalidate the core dlc cache */
steam_core_dlc_list_t *list;
steam_get_core_dlcs(&list, false);
strlcpy(msg, msg_hash_to_str(MSG_CORE_INSTALLED),
sizeof(msg));
strlcat(msg, state->name,