mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-09 21:45:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid hard crash when capturing screenshot in emulating mailbox. (#13315)

Browse Source 
The emulating mailbox infrastructure is very hacky and needs a rethink
to be able to properly support screenshots. emulating mailbox is pretty
nasty to begin with and should be considered a hack.
This commit is contained in:
Hans-Kristian Arntzen 2021-12-03 16:19:49 +01:00 committed by GitHub
parent 4a39630c0f
commit ce8a3db4dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gfx/drivers/vulkan.c
View File

@ -2743,6 +2743,12 @@ static bool vulkan_read_viewport(void *data, uint8_t *buffer, bool is_idle)
slock_unlock(vk->context->queue_lock); slock_unlock(vk->context->queue_lock);
#endif #endif
if (!staging->memory)
{
RARCH_ERR("[Vulkan]: Attempted to readback synchronously, but no image is present.\nThis can happen if vsync is disabled on Windows systems due to mailbox emulation.\n");
return false;
}
if (!staging->mapped) if (!staging->mapped)
{ {
VK_MAP_PERSISTENT_TEXTURE(vk->context->device, staging); VK_MAP_PERSISTENT_TEXTURE(vk->context->device, staging);