mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-09 21:45:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix menu rendering with Mali GPUs after changing video dimensions

Browse Source
This commit is contained in:
jdgleaver 2019-10-28 14:33:22 +00:00
parent 14f8ee1e40
commit c9b8164b0c
1 changed files with 36 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
menu/drivers_display/menu_display_gl.c
View File

@ -147,8 +147,10 @@ menu_display_gl_discard_draw_rectangle(menu_display_ctx_draw_t *draw,
video_frame_info_t *video_info video_frame_info_t *video_info
) )
{ {
static bool mali_4xx_detected = false; static bool mali_4xx_detected = false;
static bool scissor_inited = false; static bool scissor_inited = false;
static unsigned last_video_width = 0;
static unsigned last_video_height = 0;
if (!scissor_inited) if (!scissor_inited)
{ {
@ -156,12 +158,11 @@ menu_display_gl_discard_draw_rectangle(menu_display_ctx_draw_t *draw,
const char *gpu_device_string = NULL; const char *gpu_device_string = NULL;
scissor_inited = true; scissor_inited = true;
if ((scx0 + scx1 + scy0 + scy1) == 0) scissor_set_rectangle(0,
scissor_set_rectangle(0, video_info->width - 1,
video_info->width - 1, 0,
0, video_info->height - 1,
video_info->height - 1, 0);
0);
/* TODO/FIXME - This might be thread unsafe in the long run - /* TODO/FIXME - This might be thread unsafe in the long run -
* preferably call this once outside of the menu display driver * preferably call this once outside of the menu display driver
@ -181,20 +182,39 @@ menu_display_gl_discard_draw_rectangle(menu_display_ctx_draw_t *draw,
} }
} }
} }
last_video_width = video_info->width;
last_video_height = video_info->height;
} }
/* discards not only out-of-bounds scissoring, /* Early out, to minimise performance impact on
* non-mali_4xx devices */
if (!mali_4xx_detected)
return false;
/* Have to update scissor_set_rectangle() if the
* video dimensions change */
if ((video_info->width != last_video_width) ||
(video_info->height != last_video_height))
{
scissor_set_rectangle(0,
video_info->width - 1,
0,
video_info->height - 1,
0);
last_video_width = video_info->width;
last_video_height = video_info->height;
}
/* Discards not only out-of-bounds scissoring,
* but also out-of-view draws. * but also out-of-view draws.
* *
* This is intentional. * This is intentional.
*/ */
if (mali_4xx_detected && return scissor_is_outside_rectangle(
scissor_is_outside_rectangle( draw->x, draw->x + draw->width - 1,
draw->x, draw->x + draw->width - 1, draw->y, draw->y + draw->height - 1);
draw->y, draw->y + draw->height - 1))
return true;
return false;
} }
#endif #endif