mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-01 13:20:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

task_database: fix memory leak

Browse Source
This commit is contained in:
Brian Koropoff 2017-09-17 17:46:02 -07:00
parent 6c1044a699
commit c6c090052e
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tasks/task_database_cue.c
View File

@ -424,6 +424,10 @@ int cue_find_track(const char *cue_path, bool first,
size_t largest = 0; size_t largest = 0;
ssize_t volatile file_size = -1; ssize_t volatile file_size = -1;
bool is_data = false; bool is_data = false;
char *cue_dir = (char*)malloc(PATH_MAX_LENGTH);
cue_dir[0] = '\0';
fill_pathname_basedir(cue_dir, cue_path, PATH_MAX_LENGTH);
info.type = INTFSTREAM_FILE; info.type = INTFSTREAM_FILE;
@ -450,9 +454,6 @@ int cue_find_track(const char *cue_path, bool first,
{ {
if (string_is_equal(tmp_token, "FILE")) if (string_is_equal(tmp_token, "FILE"))
{ {
char *cue_dir = (char*)malloc(PATH_MAX_LENGTH);
cue_dir[0] = '\0';
/* Set last index to last EOF */ /* Set last index to last EOF */
if (file_size != -1) { if (file_size != -1) {
last_index = file_size; last_index = file_size;
@ -467,14 +468,11 @@ int cue_find_track(const char *cue_path, bool first,
} }
} }
fill_pathname_basedir(cue_dir, cue_path, PATH_MAX_LENGTH);
get_token(fd, tmp_token, MAX_TOKEN_LEN); get_token(fd, tmp_token, MAX_TOKEN_LEN);
fill_pathname_join(last_file, cue_dir, tmp_token, PATH_MAX_LENGTH); fill_pathname_join(last_file, cue_dir, tmp_token, PATH_MAX_LENGTH);
file_size = get_file_size(last_file); file_size = get_file_size(last_file);
free(cue_dir);
get_token(fd, tmp_token, MAX_TOKEN_LEN); get_token(fd, tmp_token, MAX_TOKEN_LEN);
} }
@ -524,12 +522,14 @@ int cue_find_track(const char *cue_path, bool first,
} }
clean: clean:
free(cue_dir);
free(tmp_token); free(tmp_token);
free(last_file); free(last_file);
intfstream_close(fd); intfstream_close(fd);
return rv; return rv;
error: error:
free(cue_dir);
free(tmp_token); free(tmp_token);
free(last_file); free(last_file);
if (fd) if (fd)