mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-29 22:20:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Qt: fix signedness comparisons

Browse Source
This commit is contained in:
Brad Parker 2018-09-21 16:40:31 -04:00
parent 329d472ee7
commit c2a09b4d9c
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ui/drivers/qt/playlistentrydialog.cpp
View File

@ -147,9 +147,9 @@ void PlaylistEntryDialog::loadPlaylistOptions()
hash["ui_display_name"] = ui_display_name;
for (j = 0; j < databases.count(); j++)
for (j = 0; static_cast<int>(j) < databases.count(); j++)
{
QString database = databases.at(j);
QString database = databases.at(static_cast<int>(j));
if (database.isEmpty())
continue;
@ -165,16 +165,16 @@ void PlaylistEntryDialog::loadPlaylistOptions()
std::sort(allCores.begin(), allCores.end(), comp_hash_ui_display_name_key_lower);
std::sort(allDatabases.begin(), allDatabases.end(), comp_string_lower);
for (j = 0; j < allCores.count(); j++)
for (j = 0; static_cast<int>(j) < allCores.count(); j++)
{
const QHash<QString, QString> &hash = allCores.at(j);
const QHash<QString, QString> &hash = allCores.at(static_cast<int>(j));
m_coreComboBox->addItem(hash.value("ui_display_name"), QVariant::fromValue(hash));
}
for (j = 0; j < allDatabases.count(); j++)
for (j = 0; static_cast<int>(j) < allDatabases.count(); j++)
{
QString database = allDatabases.at(j);
QString database = allDatabases.at(static_cast<int>(j));
m_databaseComboBox->addItem(database, database);
}
}

8
ui/drivers/qt/shaderparamsdialog.cpp
View File

@ -974,7 +974,7 @@ void ShaderParamsDialog::buildLayout()
*/
if (menu_shader)
{
for (i = 0; i < static_cast<int>(menu_shader->passes); i++)
for (i = 0; i < menu_shader->passes; i++)
{
QFileInfo fileInfo(menu_shader->pass[i].source.path);
QString shaderBasename = fileInfo.completeBaseName();
@ -999,7 +999,7 @@ void ShaderParamsDialog::buildLayout()
m_layout->addLayout(topButtonLayout);
/* NOTE: We assume that parameters are always grouped in order by the pass number, e.g., all parameters for pass 0 come first, then params for pass 1, etc. */
for (i = 0; avail_shader && i < static_cast<int>(avail_shader->passes); i++)
for (i = 0; avail_shader && i < avail_shader->passes; i++)
{
QFormLayout *form = NULL;
QGroupBox *groupBox = NULL;
@ -1030,7 +1030,7 @@ void ShaderParamsDialog::buildLayout()
moveUpButton->setProperty("pass", i);
/* Can't move down if we're already at the bottom. */
if (i < static_cast<int>(avail_shader->passes) - 1)
if (i < avail_shader->passes - 1)
connect(moveDownButton, SIGNAL(clicked()), this, SLOT(onShaderPassMoveDownClicked()));
else
moveDownButton->setDisabled(true);
@ -1105,7 +1105,7 @@ void ShaderParamsDialog::buildLayout()
{
struct video_shader_parameter *param = &avail_shader->parameters[j];
if (param->pass != i)
if (param->pass != static_cast<int>(i))
continue;
addShaderParam(param, form);