mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-16 08:43:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Builtin cores like ffmpeg and imageviewer would previously try

Browse Source 
to erroneously load a dynamic core named 'builtin' - this would
fail and would just be a wasteful operation - this now skips
dylib loading in libretro_get_system_info for builtin cores
This commit is contained in:
twinaphex 2020-06-08 18:40:45 +02:00
parent 6fce0435a1
commit b97462c8a4
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
retroarch.c
View File

@ -18503,6 +18503,9 @@ static bool libretro_get_system_info(
dylib_t lib; dylib_t lib;
#endif #endif
if (string_ends_with(path, "builtin"))
return false;
dummy_info.library_name = NULL; dummy_info.library_name = NULL;
dummy_info.library_version = NULL; dummy_info.library_version = NULL;
dummy_info.valid_extensions = NULL; dummy_info.valid_extensions = NULL;
@ -34043,7 +34046,16 @@ static void retroarch_parse_input_and_config(
#ifdef HAVE_DYNAMIC #ifdef HAVE_DYNAMIC
case 'L': case 'L':
{ {
int path_stats = path_stat(optarg); int path_stats;
if (string_ends_with(optarg, "builtin"))
{
RARCH_LOG("--libretro argument \"%s\" is a built-in core. Ignoring.\n",
optarg);
break;
}
path_stats = path_stat(optarg);
if ((path_stats & RETRO_VFS_STAT_IS_DIRECTORY) != 0) if ((path_stats & RETRO_VFS_STAT_IS_DIRECTORY) != 0)
{ {