mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-03 13:14:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to move access call to maybe prevent 'time of check time of use'

Browse Source 
coverity error
This commit is contained in:
twinaphex 2017-06-07 23:29:29 +02:00
parent 5c84f9158e
commit ab087faa2a
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
input/drivers_joypad/linuxraw_joypad.c
View File

@ -85,16 +85,14 @@ static void linuxraw_poll_pad(struct linuxraw_joypad *pad)
static bool linuxraw_joypad_init_pad(const char *path,
struct linuxraw_joypad *pad)
{
if (pad->fd >= 0)
return false;
/* Device can have just been created, but not made accessible (yet).
IN_ATTRIB will signal when permissions change. */
if (access(path, R_OK) < 0)
return false;
if (pad->fd >= 0)
return false;
pad->fd = open(path, O_RDONLY | O_NONBLOCK);
*pad->ident = '\0';
if (pad->fd >= 0)
@ -107,13 +105,10 @@ static bool linuxraw_joypad_init_pad(const char *path,
else
RARCH_ERR("[Device]: Didn't find ident of %s.\n", path);
if (!epoll_add(&linuxraw_epoll, pad->fd, pad))
goto error;
if (epoll_add(&linuxraw_epoll, pad->fd, pad))
return true;
}
error:
RARCH_ERR("[Device]: Failed to open pad %s (error: %s).\n",
path, strerror(errno));
return false;