From bf47ceef2bdc2362253b2900fe0bde169e019b39 Mon Sep 17 00:00:00 2001 From: Mike Robinson Date: Tue, 2 Sep 2014 00:30:37 +0100 Subject: [PATCH] Fix spurious error message in init_movie() g_extern.bsv.movie was checked before bsv_movie_init, resulting in failure report even if recording succeeded. --- retroarch.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/retroarch.c b/retroarch.c index 7018c40383..d1a758fe7a 100644 --- a/retroarch.c +++ b/retroarch.c @@ -1680,18 +1680,19 @@ static void init_movie(void) g_extern.bsv.movie_start_path); msg_queue_clear(g_extern.msg_queue); - msg_queue_push(g_extern.msg_queue, - g_extern.bsv.movie ? msg : "Failed to start movie record.", 1, 180); - if ((g_extern.bsv.movie = bsv_movie_init(g_extern.bsv.movie_start_path, RARCH_MOVIE_RECORD))) { + msg_queue_push(g_extern.msg_queue, msg, 1, 180); RARCH_LOG("Starting movie record to \"%s\".\n", g_extern.bsv.movie_start_path); g_settings.rewind_granularity = 1; } else + { + msg_queue_push(g_extern.msg_queue, "Failed to start movie record.", 1, 180); RARCH_ERR("Failed to start movie record.\n"); + } } }