mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-12 22:14:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

apple: small changes necessary to get ffmpeg record driver working (#17145)

Browse Source
This commit is contained in:
Eric Warmenhoven 2024-11-01 02:42:35 -04:00 committed by GitHub
parent b8b0de3716
commit a51160a155
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
record/record_driver.c
View File

@ -71,10 +71,7 @@ const char* config_get_record_driver_options(void)
return char_list_new_special(STRING_LIST_RECORD_DRIVERS, NULL); return char_list_new_special(STRING_LIST_RECORD_DRIVERS, NULL);
} }
#if 0 static void find_record_driver(void)
/* TODO/FIXME - not used apparently */
static void find_record_driver(const char *prefix,
bool verbosity_enabled)
{ {
settings_t *settings = config_get_ptr(); settings_t *settings = config_get_ptr();
int i = (int)driver_find_index( int i = (int)driver_find_index(
@ -85,16 +82,16 @@ static void find_record_driver(const char *prefix,
recording_state.driver = (const record_driver_t*)record_drivers[i]; recording_state.driver = (const record_driver_t*)record_drivers[i];
else else
{ {
if (verbosity_enabled) if (verbosity_is_enabled())
{ {
unsigned d; unsigned d;
RARCH_ERR("[Recording]: Couldn't find any %s named \"%s\".\n", prefix, RARCH_ERR("[Recording]: Couldn't find any record driver named \"%s\".\n",
settings->arrays.record_driver); settings->arrays.record_driver);
RARCH_LOG_OUTPUT("Available %ss are:\n", prefix); RARCH_LOG_OUTPUT("Available record drivers are:\n");
for (d = 0; record_drivers[d]; d++) for (d = 0; record_drivers[d]; d++)
RARCH_LOG_OUTPUT("\t%s\n", record_drivers[d].ident); RARCH_LOG_OUTPUT("\t%s\n", record_drivers[d]->ident);
RARCH_WARN("[Recording]: Going to default to first %s...\n", prefix); RARCH_WARN("[Recording]: Going to default to first record driver...\n");
} }
recording_state.driver = (const record_driver_t*)record_drivers[0]; recording_state.driver = (const record_driver_t*)record_drivers[0];
@ -104,6 +101,8 @@ static void find_record_driver(const char *prefix,
} }
} }
#if 0
/* TODO/FIXME - not used apparently */
/** /**
* ffemu_find_backend: * ffemu_find_backend:
* @ident : Identifier of driver to find. * @ident : Identifier of driver to find.
@ -149,26 +148,15 @@ static void recording_driver_free_state(void)
* *
* @return true if successful, otherwise false. * @return true if successful, otherwise false.
**/ **/
static bool record_driver_init_first( static bool record_driver_init(
const record_driver_t **backend, void **data,
const struct record_params *params) const struct record_params *params)
{ {
unsigned i; find_record_driver();
if (!recording_state.driver)
return false;
for (i = 0; record_drivers[i]; i++) recording_state.data = recording_state.driver->init(params);
{ return recording_state.data != NULL;
void *handle = NULL;
if (!record_drivers[i]->init)
continue;
if (!(handle = record_drivers[i]->init(params)))
continue;
*backend = record_drivers[i];
*data = handle;
return true;
}
return false;
} }
bool recording_deinit(void) bool recording_deinit(void)
@ -286,6 +274,8 @@ bool recording_init(void)
else else
{ {
const char *game_name = path_basename(path_get(RARCH_PATH_BASENAME)); const char *game_name = path_basename(path_get(RARCH_PATH_BASENAME));
if (!path_is_directory(recording_st->output_dir))
path_mkdir(recording_st->output_dir);
/* Fallback to core name if started without content */ /* Fallback to core name if started without content */
if (string_is_empty(game_name)) if (string_is_empty(game_name))
game_name = runloop_st->system.info.library_name; game_name = runloop_st->system.info.library_name;
@ -448,9 +438,7 @@ bool recording_init(void)
params.fb_width, params.fb_height, params.fb_width, params.fb_height,
(unsigned)params.pix_fmt); (unsigned)params.pix_fmt);
if (!record_driver_init_first( if (!record_driver_init(&params))
&recording_state.driver,
&recording_state.data, &params))
{ {
RARCH_ERR("[Recording]: %s\n", RARCH_ERR("[Recording]: %s\n",
msg_hash_to_str(MSG_FAILED_TO_START_RECORDING)); msg_hash_to_str(MSG_FAILED_TO_START_RECORDING));