mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-03 13:14:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add global state warnings

Browse Source
This commit is contained in:
twinaphex 2020-05-29 06:10:53 +02:00
parent 8cf3a48106
commit a50fd86f3e
5 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/task_autodetect.c
View File

@ -42,6 +42,7 @@ struct autoconfig_disconnect
char *msg; char *msg;
}; };
/* TODO/FIXME - global state - perhaps move outside this file */
static bool input_autoconfigured[MAX_USERS]; static bool input_autoconfigured[MAX_USERS];
static unsigned input_device_name_index[MAX_INPUT_DEVICES]; static unsigned input_device_name_index[MAX_INPUT_DEVICES];
static bool input_autoconfigure_swap_override; static bool input_autoconfigure_swap_override;

7
tasks/task_autodetect_blissbox.c
View File

@ -76,7 +76,7 @@ const GUID GUID_NULL = {0, 0, 0, {0, 0, 0, 0, 0, 0, 0, 0}};
#define USB_PACKET_CTRL_LEN 5 #define USB_PACKET_CTRL_LEN 5
#define USB_TIMEOUT 5000 /* timeout in ms */ #define USB_TIMEOUT 5000 /* timeout in ms */
const blissbox_pad_type_t blissbox_pad_types[] = static const blissbox_pad_type_t blissbox_pad_types[] =
{ {
{"A5200", 6}, {"A5200", 6},
{"A5200_TB", 50}, {"A5200_TB", 50},
@ -142,10 +142,9 @@ const blissbox_pad_type_t blissbox_pad_types[] =
{NULL, 0}, /* used to mark unconnected ports, do not remove */ {NULL, 0}, /* used to mark unconnected ports, do not remove */
}; };
/* TODO/FIXME - global state - perhaps move outside this file */
/* only one blissbox per machine is currently supported */ /* Only one blissbox per machine is currently supported */
static const blissbox_pad_type_t *blissbox_pads[BLISSBOX_MAX_PADS] = {NULL}; static const blissbox_pad_type_t *blissbox_pads[BLISSBOX_MAX_PADS] = {NULL};
#ifdef HAVE_LIBUSB #ifdef HAVE_LIBUSB
static struct libusb_device_handle *autoconfig_libusb_handle = NULL; static struct libusb_device_handle *autoconfig_libusb_handle = NULL;
#endif #endif

1
tasks/task_content.c
View File

@ -206,6 +206,7 @@ typedef struct content_state
struct string_list *temporary_content; struct string_list *temporary_content;
} content_state_t; } content_state_t;
/* TODO/FIXME - global state - perhaps move outside this file */
static content_state_t content_st; static content_state_t content_st;
#ifdef HAVE_CDROM #ifdef HAVE_CDROM

7
tasks/task_powerstate.c
View File

@ -22,9 +22,6 @@
#include "../../frontend/frontend_driver.h" #include "../../frontend/frontend_driver.h"
#include "tasks_internal.h" #include "tasks_internal.h"
static int powerstate_percent = 0;
static enum frontend_powerstate powerstate_status = FRONTEND_POWERSTATE_NONE;
typedef struct powerstate powerstate_t; typedef struct powerstate powerstate_t;
struct powerstate struct powerstate
@ -33,6 +30,10 @@ struct powerstate
int percent; int percent;
}; };
/* TODO/FIXME - global state - perhaps move outside this file */
static int powerstate_percent = 0;
static enum frontend_powerstate powerstate_status = FRONTEND_POWERSTATE_NONE;
enum frontend_powerstate get_last_powerstate(int *percent) enum frontend_powerstate get_last_powerstate(int *percent)
{ {
if (percent) if (percent)

24
tasks/task_save.c
View File

@ -105,16 +105,6 @@ typedef struct
bool compress_files; bool compress_files;
} save_task_state_t; } save_task_state_t;
typedef save_task_state_t load_task_data_t;
/* Holds the previous saved state
* Can be restored to disk with undo_save_state(). */
static struct save_state_buf undo_save_buf;
/* Holds the data from before a load_state() operation
* Can be restored with undo_load_state(). */
static struct save_state_buf undo_load_buf;
#ifdef HAVE_THREADS #ifdef HAVE_THREADS
typedef struct autosave autosave_t; typedef struct autosave autosave_t;
@ -139,9 +129,23 @@ struct autosave
scond_t *cond; scond_t *cond;
sthread_t *thread; sthread_t *thread;
}; };
#endif
typedef save_task_state_t load_task_data_t;
/* Holds the previous saved state
* Can be restored to disk with undo_save_state(). */
/* TODO/FIXME - global state - perhaps move outside this file */
static struct save_state_buf undo_save_buf;
/* Holds the data from before a load_state() operation
* Can be restored with undo_load_state(). */
static struct save_state_buf undo_load_buf;
/* TODO/FIXME - global state - perhaps move outside this file */
static struct autosave_st autosave_state; static struct autosave_st autosave_state;
#ifdef HAVE_THREADS
/** /**
* autosave_thread: * autosave_thread:
* @data : pointer to autosave object * @data : pointer to autosave object