From a3de207fbd616efa80f649fb1d89eb612c27984a Mon Sep 17 00:00:00 2001 From: Themaister Date: Sun, 23 Feb 2014 23:04:18 +0100 Subject: [PATCH] Clarify check_variables(). --- libretro-test/libretro-test.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libretro-test/libretro-test.c b/libretro-test/libretro-test.c index 5d46a823f6..7157e63234 100644 --- a/libretro-test/libretro-test.c +++ b/libretro-test/libretro-test.c @@ -276,6 +276,11 @@ static void check_variables(void) retro_get_system_av_info(&info); if ((last != last_aspect && last != 0.0f) || (last_rate != last_sample_rate && last_rate != 0.0f)) { + // SET_SYSTEM_AV_INFO can only be called within retro_run(). + // check_variables() is called once in retro_load_game(), but the checks + // on last and last_rate ensures this path is never hit that early. + // last_aspect and last_sample_rate are not updated until retro_get_system_av_info(), + // which must come after retro_load_game(). bool ret = environ_cb(RETRO_ENVIRONMENT_SET_SYSTEM_AV_INFO, &info); logging.log(RETRO_LOG_INFO, "SET_SYSTEM_AV_INFO = %u.\n", ret); }