mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-17 20:43:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid potential segfaults if files are deleted.

Browse Source 
Potentially, on a refresh, selection_ptr could be out of range
if files have been removed.
This commit is contained in:
Themaister 2013-04-16 12:32:03 +02:00
parent fa5e8b646c
commit a0f7a184fd
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/menu/rgui.c
View File

@ -2005,8 +2005,14 @@ int rgui_iterate(rgui_handle_t *rgui, rgui_action_t action)
{ {
rgui->need_refresh = false; rgui->need_refresh = false;
rgui_list_clear(rgui->selection_buf); rgui_list_clear(rgui->selection_buf);
directory_parse(rgui, dir, menu_type, rgui->selection_buf); directory_parse(rgui, dir, menu_type, rgui->selection_buf);
// Before a refresh, we could have deleted a file on disk, causing
// selection_ptr to suddendly be out of range. Ensure it doesn't overflow.
if (rgui->selection_ptr >= rgui->selection_buf->size && rgui->selection_buf->size)
rgui->selection_ptr = rgui->selection_buf->size - 1;
else if (!rgui->selection_buf->size)
rgui->selection_ptr = 0;
} }
render_text(rgui); render_text(rgui);