From 9dd6e85d2f42a28d15427f8d24477f179c619797 Mon Sep 17 00:00:00 2001
From: Eric Warmenhoven <eric@warmenhoven.org>
Date: Thu, 2 Jan 2025 00:17:00 -0500
Subject: [PATCH] fix writing before string when substring is not found
 (#17330)

---
 menu/menu_displaylist.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/menu/menu_displaylist.c b/menu/menu_displaylist.c
index 0db738a56e..c8791dccce 100644
--- a/menu/menu_displaylist.c
+++ b/menu/menu_displaylist.c
@@ -866,12 +866,15 @@ static int menu_displaylist_parse_core_info(
             /* Show relevant note row and skip showing it later */
             if (core_info->notes)
             {
+               int spc;
                unsigned j;
                char firmware_basename[64];
                fill_pathname_base(firmware_basename,
                      core_info->firmware[i].desc, sizeof(firmware_basename));
 
-               firmware_basename[string_find_index_substring_string(firmware_basename, " ")] = '\0';
+               spc = string_find_index_substring_string(firmware_basename, " ");
+               if (spc >= 0)
+                  firmware_basename[spc] = '\0';
 
                for (j = 0; j < core_info->note_list->size; j++)
                {