Silence some Coverity warnings

This commit is contained in:
twinaphex 2017-11-26 01:06:48 +01:00
parent 0dfb6e2c64
commit 9875bbbd7d
3 changed files with 12 additions and 15 deletions

View File

@ -3549,8 +3549,7 @@ bool config_save_autoconf_profile(const char *path, unsigned user)
config_file_free(conf); config_file_free(conf);
free(buf); free(buf);
free(autoconf_file); free(autoconf_file);
if (path_new) free(path_new);
free(path_new);
return ret; return ret;
error: error:

View File

@ -274,9 +274,10 @@ void filebrowser_parse(void *data, unsigned type_data)
} }
end: end:
menu_entries_prepend(info->list, if (info)
msg_hash_to_str(MENU_ENUM_LABEL_VALUE_PARENT_DIRECTORY), menu_entries_prepend(info->list,
path, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_PARENT_DIRECTORY),
MENU_ENUM_LABEL_PARENT_DIRECTORY, path,
FILE_TYPE_PARENT_DIRECTORY, 0, 0); MENU_ENUM_LABEL_PARENT_DIRECTORY,
FILE_TYPE_PARENT_DIRECTORY, 0, 0);
} }

View File

@ -338,16 +338,13 @@ bool netplay_lan_ad_server(netplay_t *netplay)
snprintf(port_str, 6, "%hu", ntohs(((struct sockaddr_in*)(&their_addr))->sin_port)); snprintf(port_str, 6, "%hu", ntohs(((struct sockaddr_in*)(&their_addr))->sin_port));
if (getaddrinfo_retro(reply_addr, port_str, &hints, &our_addr) < 0) if (getaddrinfo_retro(reply_addr, port_str, &hints, &our_addr) < 0)
continue; continue;
else
{
RARCH_LOG ("[discovery] sending reply to %s \n", reply_addr);
/* And send it */ RARCH_LOG ("[discovery] sending reply to %s \n", reply_addr);
sendto(lan_ad_server_fd, (const char*)&ad_packet_buffer,
/* And send it */
sendto(lan_ad_server_fd, (const char*)&ad_packet_buffer,
sizeof(struct ad_packet), 0, our_addr->ai_addr, our_addr->ai_addrlen); sizeof(struct ad_packet), 0, our_addr->ai_addr, our_addr->ai_addrlen);
} freeaddrinfo_retro(our_addr);
if (our_addr)
freeaddrinfo_retro(our_addr);
} }
else else
continue; continue;