mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-24 15:02:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

cheevos: do not show "0 of 0 cheevos unlocked" msg

Browse Source 
**This will happen only if `cheevos_verbose_enable = true`.**

When loading a game tha doesn't have any achievement, instead of showing an OSD message saying "You have 0 of 0 achievements unlocked." just say "This game doesn't have any achievement."

I've just added an `if(cheevos_locals.core.count > 0)` and added indentation. The diff makes it look like it got more changes than it actually got.
This commit is contained in:
meleu 2017-11-22 12:56:17 -02:00 committed by GitHub
parent d5f950a624
commit 8e0ee72283
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
cheevos/cheevos.c
View File

@ -2830,25 +2830,31 @@ static int cheevos_iterate(coro_t* coro)
if(CHEEVOS_VAR_SETTINGS->bools.cheevos_verbose_enable) if(CHEEVOS_VAR_SETTINGS->bools.cheevos_verbose_enable)
{ {
const cheevo_t* cheevo = cheevos_locals.core.cheevos; if(cheevos_locals.core.count > 0)
const cheevo_t* end = cheevo + cheevos_locals.core.count; {
int number_of_unlocked = cheevos_locals.core.count; const cheevo_t* cheevo = cheevos_locals.core.cheevos;
int mode; const cheevo_t* end = cheevo + cheevos_locals.core.count;
char msg[256]; int number_of_unlocked = cheevos_locals.core.count;
int mode;
char msg[256];
if(CHEEVOS_VAR_SETTINGS->bools.cheevos_hardcore_mode_enable) if(CHEEVOS_VAR_SETTINGS->bools.cheevos_hardcore_mode_enable)
mode = CHEEVOS_ACTIVE_HARDCORE; mode = CHEEVOS_ACTIVE_HARDCORE;
else
mode = CHEEVOS_ACTIVE_SOFTCORE;
for(; cheevo < end; cheevo++)
if(cheevo->active & mode)
number_of_unlocked--;
snprintf(msg, sizeof(msg), "You have %d of %d achievements unlocked.",
number_of_unlocked, cheevos_locals.core.count);
msg[sizeof(msg) - 1] = 0;
runloop_msg_queue_push(msg, 0, 6 * 60, false);
}
else else
mode = CHEEVOS_ACTIVE_SOFTCORE; runloop_msg_queue_push("This game doesn't have any achievement.", 0, 5 * 60, false);
for(; cheevo < end; cheevo++)
if(cheevo->active & mode)
number_of_unlocked--;
snprintf(msg, sizeof(msg), "You have %d of %d achievements unlocked.",
number_of_unlocked, cheevos_locals.core.count);
msg[sizeof(msg) - 1] = 0;
runloop_msg_queue_push(msg, 0, 6 * 60, false);
} }
CORO_STOP(); CORO_STOP();