mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-01 07:13:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Net HTTP) Avoid unnecessary snprintf

Browse Source
This commit is contained in:
twinaphex 2019-09-17 05:26:00 +02:00
parent 861262ef3a
commit 6f6b1a8333
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libretro-common/net/net_http.c
View File

@ -142,6 +142,7 @@ void net_http_urlencode(char **dest, const char *source)
void net_http_urlencode_full(char *dest, void net_http_urlencode_full(char *dest,
const char *source, size_t size) const char *source, size_t size)
{ {
size_t copied = 0;
char *tmp = NULL; char *tmp = NULL;
char url_domain[PATH_MAX_LENGTH] = {0}; char url_domain[PATH_MAX_LENGTH] = {0};
char url_path[PATH_MAX_LENGTH] = {0}; char url_path[PATH_MAX_LENGTH] = {0};
@ -164,9 +165,12 @@ void net_http_urlencode_full(char *dest,
strlen(tmp) + 1 strlen(tmp) + 1
); );
tmp = NULL; tmp = NULL;
net_http_urlencode(&tmp, url_path); net_http_urlencode(&tmp, url_path);
snprintf(dest, size, "%s/%s", url_domain, tmp); copied = strlcpy(dest, url_domain, size);
dest[copied] = '/';
dest[copied+1] = '\0';
copied = strlcat(dest, tmp, size);
free (tmp); free (tmp);
} }
@ -478,7 +482,7 @@ struct http_t *net_http_new(struct http_connection_t *conn)
net_http_send_str(&conn->sock_state, &error, "\r\n"); net_http_send_str(&conn->sock_state, &error, "\r\n");
/* this is not being set anywhere yet */ /* This is not being set anywhere yet */
if (conn->contenttypecopy) if (conn->contenttypecopy)
{ {
net_http_send_str(&conn->sock_state, &error, "Content-Type: "); net_http_send_str(&conn->sock_state, &error, "Content-Type: ");