diff --git a/console/rarch_console_libretro_mgmt.c b/console/rarch_console_libretro_mgmt.c index 41464f0be8..16475cb5e7 100644 --- a/console/rarch_console_libretro_mgmt.c +++ b/console/rarch_console_libretro_mgmt.c @@ -50,57 +50,51 @@ void rarch_console_name_from_id(char *name, size_t size) } } -bool rarch_configure_libretro_core(const char *core_exe_path, const char *tmp_path, +// if a CORE executable exists (full_path), this means we have just installed +// a new libretro port and therefore we need to change it to a more +// sane name. + +bool rarch_libretro_core_install(const char *core_exe_path, const char *tmp_path, const char *libretro_path, const char *config_path, const char *extension) { - bool upgrade_core_succeeded = false; + int ret = 0; + char tmp_path2[PATH_MAX], tmp_pathnewfile[PATH_MAX]; - g_extern.verbose = true; + rarch_console_name_from_id(tmp_path2, sizeof(tmp_path2)); + strlcat(tmp_path2, extension, sizeof(tmp_path2)); + snprintf(tmp_pathnewfile, sizeof(tmp_pathnewfile), "%s%s", tmp_path, tmp_path2); - //install and rename libretro core first if 'CORE' executable exists - if (path_file_exists(core_exe_path)) + if (path_file_exists(tmp_pathnewfile)) { - bool ret = false; - char tmp_path2[PATH_MAX], tmp_pathnewfile[PATH_MAX]; + // if libretro core already exists, this means we are + // upgrading the libretro core - so delete pre-existing + // file first. - rarch_console_name_from_id(tmp_path2, sizeof(tmp_path2)); - strlcat(tmp_path2, extension, sizeof(tmp_path2)); - snprintf(tmp_pathnewfile, sizeof(tmp_pathnewfile), "%s%s", tmp_path, tmp_path2); - - if (path_file_exists(tmp_pathnewfile)) - { - // if libretro core already exists, this means we are - // upgrading the libretro core - so delete pre-existing - // file first. - - RARCH_LOG("Upgrading emulator core...\n"); - ret = remove(tmp_pathnewfile); - - if (ret == 0) - RARCH_LOG("Succeeded in removing pre-existing libretro core: [%s].\n", tmp_pathnewfile); - else - RARCH_ERR("Failed to remove pre-existing libretro core: [%s].\n", tmp_pathnewfile); - } - - //now attempt the renaming. - ret = rename(core_exe_path, tmp_pathnewfile); + RARCH_LOG("Upgrading emulator core...\n"); + ret = remove(tmp_pathnewfile); if (ret == 0) - { - RARCH_LOG("libretro core [%s] renamed to: [%s].\n", core_exe_path, tmp_pathnewfile); - snprintf(g_settings.libretro, sizeof(g_settings.libretro), tmp_pathnewfile); - upgrade_core_succeeded = true; - } + RARCH_LOG("Succeeded in removing pre-existing libretro core: [%s].\n", tmp_pathnewfile); else - { - RARCH_ERR("Failed to rename CORE executable.\n"); - RARCH_WARN("CORE executable was not found, or some other error occurred. Will attempt to load libretro core path from config file.\n"); - } + RARCH_ERR("Failed to remove pre-existing libretro core: [%s].\n", tmp_pathnewfile); } - g_extern.verbose = false; + //now attempt the renaming. + ret = rename(core_exe_path, tmp_pathnewfile); - return upgrade_core_succeeded; + if (ret == 0) + { + RARCH_LOG("Libretro core [%s] successfully renamed to: [%s].\n", core_exe_path, tmp_pathnewfile); + snprintf(g_settings.libretro, sizeof(g_settings.libretro), tmp_pathnewfile); + } + else + { + RARCH_ERR("Failed to rename CORE executable.\n"); + RARCH_WARN("CORE executable was not found, or some other error occurred. Will attempt to load libretro core path from config file.\n"); + return false; + } + + return true; } bool rarch_manage_libretro_extension_supported(const char *filename) diff --git a/console/rarch_console_libretro_mgmt.h b/console/rarch_console_libretro_mgmt.h index 825530a10f..d7b44d2595 100644 --- a/console/rarch_console_libretro_mgmt.h +++ b/console/rarch_console_libretro_mgmt.h @@ -38,10 +38,8 @@ void rarch_manage_libretro_set_first_file(char *first_file, size_t size_of_first #ifndef IS_SALAMANDER -// if a CORE executable exists (full_path), this means we have just installed -// a new libretro port and therefore we need to change it to a more -// sane name. -bool rarch_configure_libretro_core(const char *full_path, const char *tmp_path, +//install/upgrade (and rename) libretro core if 'CORE' executable exists +bool rarch_libretro_core_install(const char *full_path, const char *tmp_path, const char *libretro_path, const char *config_path, const char *extension); // Transforms a library id to a name suitable as a pathname. diff --git a/frontend/frontend_gx.c b/frontend/frontend_gx.c index 587cee0bf9..eb49217b26 100644 --- a/frontend/frontend_gx.c +++ b/frontend/frontend_gx.c @@ -511,19 +511,22 @@ int main(int argc, char *argv[]) snprintf(tmp_path, sizeof(tmp_path), "%s/", default_paths.core_dir); const char *path_prefix = tmp_path; - char full_path[1024]; - snprintf(full_path, sizeof(full_path), "%sCORE%s", path_prefix, extension); + char core_exe_path[1024]; + snprintf(core_exe_path, sizeof(core_exe_path), "%sCORE%s", path_prefix, extension); rarch_settings_set_default(); rarch_input_set_controls_default(driver.input); rarch_config_load(); #ifdef HAVE_LIBRETRO_MANAGEMENT - if (rarch_configure_libretro_core(full_path, path_prefix, path_prefix, - g_extern.config_path, extension)) + if (path_file_exists(core_exe_path)) { - RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); - config_save_file(g_extern.config_path); + if (rarch_libretro_core_install(core_exe_path, path_prefix, path_prefix, + g_extern.config_path, extension)) + { + RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); + config_save_file(g_extern.config_path); + } } #endif diff --git a/frontend/frontend_ps3.c b/frontend/frontend_ps3.c index 42b06f929c..d287e482b1 100644 --- a/frontend/frontend_ps3.c +++ b/frontend/frontend_ps3.c @@ -283,11 +283,14 @@ int main(int argc, char *argv[]) rarch_config_load(); #ifdef HAVE_LIBRETRO_MANAGEMENT - if (rarch_configure_libretro_core(core_exe_path, path_prefix, path_prefix, - g_extern.config_path, extension)) + if (path_file_exists(core_exe_path)) { - RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); - config_save_file(g_extern.config_path); + if (rarch_libretro_core_install(core_exe_path, path_prefix, path_prefix, + g_extern.config_path, extension)) + { + RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); + config_save_file(g_extern.config_path); + } } #endif diff --git a/frontend/frontend_psp.c b/frontend/frontend_psp.c index a516cbca8d..d2508c4b16 100644 --- a/frontend/frontend_psp.c +++ b/frontend/frontend_psp.c @@ -144,11 +144,14 @@ int main(int argc, char *argv[]) rarch_config_load(); #ifdef HAVE_LIBRETRO_MANAGEMENT - if (rarch_configure_libretro_core(core_exe_path, path_prefix, path_prefix, - g_extern.config_path, extension)) + if (path_file_exists(core_exe_path)) { - RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); - config_save_file(g_extern.config_path); + if (rarch_libretro_core_install(core_exe_path, path_prefix, path_prefix, + g_extern.config_path, extension)) + { + RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); + config_save_file(g_extern.config_path); + } } #endif diff --git a/frontend/frontend_xdk.c b/frontend/frontend_xdk.c index 440c8678ce..fe62434cdd 100644 --- a/frontend/frontend_xdk.c +++ b/frontend/frontend_xdk.c @@ -155,19 +155,22 @@ int main(int argc, char *argv[]) #endif const char *extension = default_paths.executable_extension; - char full_path[1024]; - snprintf(full_path, sizeof(full_path), "%sCORE%s", path_prefix, extension); + char core_exe_path[1024]; + snprintf(core_exe_path, sizeof(core_exe_path), "%sCORE%s", path_prefix, extension); rarch_settings_set_default(); rarch_input_set_controls_default(driver.input); rarch_config_load(); #ifdef HAVE_LIBRETRO_MANAGEMENT - if (rarch_configure_libretro_core(full_path, path_prefix, path_prefix, - g_extern.config_path, extension)) + if (path_file_exists(core_exe_path)) { - RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); - config_save_file(g_extern.config_path); + if (rarch_libretro_core_install(core_exe_path, path_prefix, path_prefix, + g_extern.config_path, extension)) + { + RARCH_LOG("New default libretro core saved to config file: %s.\n", g_settings.libretro); + config_save_file(g_extern.config_path); + } } #endif