mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-18 05:43:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

(jdgleaver) Initialize string lists properly to prevent memory leaks

Browse Source
This commit is contained in:
twinaphex 2020-08-25 13:25:27 +02:00
parent ce185d8be6
commit 6af6d5eb1c
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core_info.c
View File

@ -261,8 +261,8 @@ static core_info_list_t *core_info_list_new(const char *path,
const char *exts, const char *exts,
bool dir_show_hidden_files) bool dir_show_hidden_files)
{ {
struct string_list contents;
size_t i; size_t i;
struct string_list contents = {0};
core_info_t *core_info = NULL; core_info_t *core_info = NULL;
core_info_list_t *core_info_list = NULL; core_info_list_t *core_info_list = NULL;
const char *path_basedir = libretro_info_dir; const char *path_basedir = libretro_info_dir;

2
gfx/drivers_shader/slang_process.cpp
View File

@ -428,7 +428,7 @@ bool slang_preprocess_parse_parameters(const char *shader_path,
struct video_shader *shader) struct video_shader *shader)
{ {
glslang_meta meta; glslang_meta meta;
struct string_list lines; struct string_list lines = {0};
if (!string_list_initialize(&lines)) if (!string_list_initialize(&lines))
goto error; goto error;

2
menu/cbs/menu_cbs_deferred_push.c
View File

@ -536,9 +536,9 @@ static int general_push(menu_displaylist_info_t *info,
case PUSH_ARCHIVE_OPEN_DETECT_CORE: case PUSH_ARCHIVE_OPEN_DETECT_CORE:
case PUSH_DETECT_CORE_LIST: case PUSH_DETECT_CORE_LIST:
{ {
struct string_list str_list2;
union string_list_elem_attr attr; union string_list_elem_attr attr;
char newstring[PATH_MAX_LENGTH]; char newstring[PATH_MAX_LENGTH];
struct string_list str_list2 = {0};
struct retro_system_info *system = runloop_get_libretro_system_info(); struct retro_system_info *system = runloop_get_libretro_system_info();
newstring[0] = '\0'; newstring[0] = '\0';

2
menu/menu_displaylist.c
View File

@ -11529,7 +11529,7 @@ bool menu_displaylist_ctl(enum menu_displaylist_ctl_state type,
menu_entries_ctl(MENU_ENTRIES_CTL_CLEAR, info->list); menu_entries_ctl(MENU_ENTRIES_CTL_CLEAR, info->list);
#if defined(HAVE_CG) || defined(HAVE_GLSL) || defined(HAVE_SLANG) || defined(HAVE_HLSL) #if defined(HAVE_CG) || defined(HAVE_GLSL) || defined(HAVE_SLANG) || defined(HAVE_HLSL)
{ {
struct string_list str_list; struct string_list str_list = {0};
char new_exts[PATH_MAX_LENGTH]; char new_exts[PATH_MAX_LENGTH];
union string_list_elem_attr attr; union string_list_elem_attr attr;

4
retroarch.c
View File

@ -11384,7 +11384,7 @@ void path_set_special(char **argv, unsigned num_content)
unsigned i; unsigned i;
char str[PATH_MAX_LENGTH]; char str[PATH_MAX_LENGTH];
union string_list_elem_attr attr; union string_list_elem_attr attr;
struct string_list subsystem_paths; struct string_list subsystem_paths = {0};
struct rarch_state *p_rarch = &rarch_st; struct rarch_state *p_rarch = &rarch_st;
global_t *global = &p_rarch->g_extern; global_t *global = &p_rarch->g_extern;
const char *savestate_dir = p_rarch->current_savestate_dir; const char *savestate_dir = p_rarch->current_savestate_dir;
@ -30041,7 +30041,7 @@ bool audio_driver_mixer_extension_supported(const char *ext)
bool ret = false; bool ret = false;
attr.i = 0; attr.i = 0;
if (string_list_initialize(&str_list)) if (!string_list_initialize(&str_list))
return false; return false;
#ifdef HAVE_STB_VORBIS #ifdef HAVE_STB_VORBIS