mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-09 21:45:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't define tag_v variable when not needed

Browse Source
This commit is contained in:
libretroadmin 2023-01-07 05:25:56 +01:00
parent f82bc4e99c
commit 5872b357e6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
verbosity.c
View File

@ -214,8 +214,6 @@ void retro_main_log_file_deinit(void)
void RARCH_LOG_V(const char *tag, const char *fmt, va_list ap) void RARCH_LOG_V(const char *tag, const char *fmt, va_list ap)
{ {
verbosity_state_t *g_verbosity = &main_verbosity_st; verbosity_state_t *g_verbosity = &main_verbosity_st;
const char *tag_v = tag ? tag : FILE_PATH_LOG_INFO;
#if TARGET_OS_IPHONE #if TARGET_OS_IPHONE
#if TARGET_IPHONE_SIMULATOR #if TARGET_IPHONE_SIMULATOR
vprintf(fmt, ap); vprintf(fmt, ap);
@ -241,8 +239,9 @@ void RARCH_LOG_V(const char *tag, const char *fmt, va_list ap)
/* FIXME: Using arbitrary string as fmt argument is unsafe. */ /* FIXME: Using arbitrary string as fmt argument is unsafe. */
char msg_new[256]; char msg_new[256];
char buffer[256]; char buffer[256];
const char *tag_v = tag ? tag : FILE_PATH_LOG_INFO;
msg_new[0] = buffer[0] = '\0'; msg_new[0] = buffer[0] = '\0';
snprintf(msg_new, sizeof(msg_new), "%s: %s %s", snprintf(msg_new, sizeof(msg_new), "%s: %s %s",
FILE_PATH_PROGRAM_NAME, tag_v, fmt); FILE_PATH_PROGRAM_NAME, tag_v, fmt);
wvsprintf(buffer, msg_new, ap); wvsprintf(buffer, msg_new, ap);
@ -265,10 +264,11 @@ void RARCH_LOG_V(const char *tag, const char *fmt, va_list ap)
else else
__android_log_vprint(prio, FILE_PATH_PROGRAM_NAME, fmt, ap); __android_log_vprint(prio, FILE_PATH_PROGRAM_NAME, fmt, ap);
#else #else
FILE *fp = (FILE*)g_verbosity->fp; FILE *fp = (FILE*)g_verbosity->fp;
const char *tag_v = tag ? tag : FILE_PATH_LOG_INFO;
#if defined(HAVE_QT) || defined(__WINRT__) #if defined(HAVE_QT) || defined(__WINRT__)
char buffer[2048]; char buffer[2048];
buffer[0] = '\0'; buffer[0] = '\0';
/* Ensure null termination and line break in error case */ /* Ensure null termination and line break in error case */
if (vsnprintf(buffer, sizeof(buffer), fmt, ap) < 0) if (vsnprintf(buffer, sizeof(buffer), fmt, ap) < 0)