mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-28 19:20:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

80-char width limit nits

Browse Source
This commit is contained in:
twinaphex 2016-02-26 15:41:28 +01:00
parent ea2094126b
commit 55abe2e38f
3 changed files with 112 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
content.c
View File

@ -404,7 +404,8 @@ struct decomp_state
bool found;
};
static bool content_zip_file_decompressed_handle(file_archive_file_handle_t *handle,
static bool content_zip_file_decompressed_handle(
file_archive_file_handle_t *handle,
const uint8_t *cdata, uint32_t csize,
uint32_t size, uint32_t crc32)
{

10
libretro.h
View File

@ -1396,13 +1396,17 @@ struct retro_camera_callback
*/
uint64_t caps;
unsigned width; /* Desired resolution for camera. Is only used as a hint. */
/* Desired resolution for camera. Is only used as a hint. */
unsigned width;
unsigned height;
retro_camera_start_t start; /* Set by frontend. */
retro_camera_stop_t stop; /* Set by frontend. */
/* Set by frontend. */
retro_camera_start_t start;
retro_camera_stop_t stop;
/* Set by libretro core if raw framebuffer callbacks will be used. */
retro_camera_frame_raw_framebuffer_t frame_raw_framebuffer;
/* Set by libretro core if OpenGL texture callbacks will be used. */
retro_camera_frame_opengl_texture_t frame_opengl_texture;

158
libretro_vulkan.h
View File

@ -51,8 +51,8 @@ typedef void (*retro_vulkan_unlock_queue_t)(void *handle);
/* Note on thread safety:
* The Vulkan API is heavily designed around multi-threading, and
* the libretro interface for it should also be threading friendly.
* A core should be able to build command buffers and submit command buffers to the GPU from
* any thread.
* A core should be able to build command buffers and submit
* command buffers to the GPU from any thread.
*/
struct retro_hw_render_interface_vulkan
@ -66,7 +66,8 @@ struct retro_hw_render_interface_vulkan
* which must be passed along to all function pointers
* in this interface.
*
* The rationale for including a handle here (which libretro v1 doesn't current do in general) is:
* The rationale for including a handle here (which libretro v1
* doesn't currently do in general) is:
*
* - Vulkan cores should be able to be freely threaded without lots of fuzz.
* This would break frontends which currently rely on TLS
@ -95,10 +96,14 @@ struct retro_hw_render_interface_vulkan
/* Before calling retro_video_refresh_t with RETRO_HW_FRAME_BUFFER_VALID,
* set which image to use for this frame.
*
* If num_semaphores is non-zero, the frontend will wait for the semaphores provided to be signaled
* before using the results further in the pipeline.
* Using semaphores is optional for synchronization purposes, but if not using
* semaphores, an image memory barrier in vkCmdPipelineBarrier should be used in the graphics_queue.
* If num_semaphores is non-zero, the frontend will wait for the
* semaphores provided to be signaled before using the results further
* in the pipeline.
*
* Using semaphores is optional for synchronization purposes,
* but if not using
* semaphores, an image memory barrier in vkCmdPipelineBarrier
* should be used in the graphics_queue.
* Example:
*
* vkCmdPipelineBarrier(cmd,
@ -109,85 +114,126 @@ struct retro_hw_render_interface_vulkan
* dstAccessMask = VK_ACCESS_SHADER_READ_BIT,
* });
*
* The use of pipeline barriers instead of semaphores is encouraged as it is simpler
* and more fine-grained. A layout transition must generally happen anyways which requires a
* The use of pipeline barriers instead of semaphores is encouraged
* as it is simpler and more fine-grained. A layout transition
* must generally happen anyways which requires a
* pipeline barrier.
*
* The image passed to set_image must have imageUsage flags set to at least
* VK_IMAGE_USAGE_TRANSFER_SRC_BIT and VK_IMAGE_USAGE_SAMPLED_BIT.
* The core will naturally want to use flags such as
* VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT and/or VK_IMAGE_USAGE_TRANSFER_DST_BIT depending
* VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT and/or
* VK_IMAGE_USAGE_TRANSFER_DST_BIT depending
* on how the final image is created.
*
* The image must also have been created with MUTABLE_FORMAT bit set if 8-bit formatt are used, so that the frontend can
* reinterpret sRGB formats as it sees fit.
* The image must also have been created with MUTABLE_FORMAT bit set if
* 8-bit formats are used, so that the frontend can reinterpret sRGB
* formats as it sees fit.
*
* Images passed to set_image should be created with TILING_OPTIMAL.
* The image layout should be transitioned to either VK_IMAGE_LAYOUT_GENERIC or VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL.
* The image layout should be transitioned to either
* VK_IMAGE_LAYOUT_GENERIC or VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL.
* The actual image layout used must be set in image_layout.
*
* The image must be a 2D texture which may or not be layered and/or mipmapped.
* The image must be a 2D texture which may or not be layered
* and/or mipmapped.
*
* The image must be suitable for linear sampling.
* While the image_view is typically the only field used,
* the frontend may want to reinterpret the texture as sRGB vs. no-sRGB for example
* so the VkImageViewCreateInfo used to create the image view must also be passed in.
* the frontend may want to reinterpret the texture as sRGB vs.
* non-sRGB for example so the VkImageViewCreateInfo used to
* create the image view must also be passed in.
*
* The data in the pointer to the image struct will not be copied
* as the pNext field in create_info cannot be reliably deep-copied.
* The image pointer passed to set_image must be valid until retro_video_refresh_t has returned.
* The image pointer passed to set_image must be valid until
* retro_video_refresh_t has returned.
*
* If frame duping is used when passing NULL to retro_video_refresh_t,
* the frontend is free to either use the latest image passed to set_image or reuse the older pointer
* passed to set_image the frame RETRO_HW_FRAME_BUFFER_VALID was last used.
* Essentially, the lifetime of the pointer passed to retro_video_refresh_t should be extended
* if frame duping is used so that the frontend can reuse the older pointer.
* the frontend is free to either use the latest image passed to
* set_image or reuse the older pointer passed to set_image the
* frame RETRO_HW_FRAME_BUFFER_VALID was last used.
*
* Essentially, the lifetime of the pointer passed to
* retro_video_refresh_t should be extended if frame duping is used
* so that the frontend can reuse the older pointer.
*
* If frame duping is used, the frontend will not wait for any semaphores.
*/
retro_vulkan_set_image_t set_image;
/* Get the current sync index for this frame which is obtained in frontend by calling
* e.g. vkAcquireNextImageKHR before calling retro_run().
* This index will correspond to which swapchain buffer is currently the active one.
* Knowing this index is very useful for maintaining safe async CPU and GPU operation without stalling.
/* Get the current sync index for this frame which is obtained in
* frontend by calling e.g. vkAcquireNextImageKHR before calling
* retro_run().
*
* The common pattern for synchronization is to receive fences when submitting command buffers
* to Vulkan (vkQueueSubmit) and add this fence to a list of fences for frame number get_sync_index().
* Next time we receive the same get_sync_index(), we can wait for the fences from before,
* which will usually return immediately as the frontend will generally also avoid letting the GPU run ahead too much.
* After the fence has signaled, we know that the GPU has completed all GPU work related to work submitted in the frame
* we last saw get_sync_index(). This means we can safely reuse or free resources allocated in this frame.
* This index will correspond to which swapchain buffer is currently
* the active one.
*
* Knowing this index is very useful for maintaining safe asynchronous CPU
* and GPU operation without stalling.
*
* The common pattern for synchronization is to receive fences when
* submitting command buffers to Vulkan (vkQueueSubmit) and add this fence
* to a list of fences for frame number get_sync_index().
*
* Next time we receive the same get_sync_index(), we can wait for the
* fences from before, which will usually return immediately as the
* frontend will generally also avoid letting the GPU run ahead too much.
*
* After the fence has signaled, we know that the GPU has completed all
* GPU work related to work submitted in the frame we last saw get_sync_index().
*
* This means we can safely reuse or free resources allocated in this frame.
*
* In theory, even if we wait for the fences correctly, it is not technically
* safe to write to the image we earlier passed to the frontend since we're
* not waiting for the frontend GPU jobs to complete.
*
* In theory, even if we wait for the fences correctly, it is not technically safe to write to the image
* we earlier passed to the frontend since we're not waiting for the frontend GPU jobs to complete.
* The frontend will guarantee that the appropriate pipeline barrier
* in graphics_queue has been used such that VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT cannot
* in graphics_queue has been used such that
* VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT cannot
* start until the frontend is done with the image.
*/
retro_vulkan_get_sync_index_t get_sync_index;
/* Returns a bitmask of how many swapchain images we currently have in the frontend.
* If bit #N is set in the return value, get_sync_index can return N.
* Knowing this value is useful for preallocating per-frame management structures ahead of time.
/* Returns a bitmask of how many swapchain images we currently have
* in the frontend.
*
* While this value will typically remain constant throughout the applications lifecycle,
* it may for example change if the frontend suddently changes fullscreen state and/or latency.
* If this value ever changes, it is safe to assume that the device is completely idle and all synchronization
* objects can be deleted right away as desired.
* If bit #N is set in the return value, get_sync_index can return N.
* Knowing this value is useful for preallocating per-frame management
* structures ahead of time.
*
* While this value will typically remain constant throughout the
* applications lifecycle, it may for example change if the frontend
* suddently changes fullscreen state and/or latency.
*
* If this value ever changes, it is safe to assume that the device
* is completely idle and all synchronization objects can be deleted
* right away as desired.
*/
retro_vulkan_get_sync_index_mask_t get_sync_index_mask;
/* Instead of submitting the command buffer to the queue first, the core can pass along
* its command buffer to the frontend, and the frontend will submit the command buffer together
* with the frontends command buffers. This has the advantage that the overhead of vkQueueSubmit
* can be amortized into a single call. For this mode, semaphores in set_image will be ignored, so
* vkCmdPipelineBarrier must be used to synchronize the core and frontend.
* The command buffers in set_command_buffers are only executed once, even if frame duping is used.
* If frame duping is used, set_image should be used for the frames which should be duped instead.
/* Instead of submitting the command buffer to the queue first, the core
* can pass along its command buffer to the frontend, and the frontend
* will submit the command buffer together with the frontends command buffers.
*
* This has the advantage that the overhead of vkQueueSubmit can be
* amortized into a single call. For this mode, semaphores in set_image
* will be ignored, so vkCmdPipelineBarrier must be used to synchronize
* the core and frontend.
*
* The command buffers in set_command_buffers are only executed once,
* even if frame duping is used.
*
* If frame duping is used, set_image should be used for the frames
* which should be duped instead.
*
* Command buffers passed to the frontend with set_command_buffers
* must not actually be submitted to the GPU until retro_video_refresh_t is called.
* The frontend must submit the command buffer before submitting any other command buffers
* provided by set_command_buffers. */
* must not actually be submitted to the GPU until retro_video_refresh_t
* is called.
*
* The frontend must submit the command buffer before submitting any
* other command buffers provided by set_command_buffers. */
retro_vulkan_set_command_buffers_t set_command_buffers;
/* Waits on CPU for device activity for the current sync index to complete.
@ -195,11 +241,13 @@ struct retro_hw_render_interface_vulkan
* when the frontend is submitting the command buffers. */
retro_vulkan_wait_sync_index_t wait_sync_index;
/* If the core submits command buffers itself to any of the queues provided in this interface,
* the core must lock and unlock the frontend from racing on the VkQueue.
/* If the core submits command buffers itself to any of the queues provided
* in this interface, the core must lock and unlock the frontend from
* racing on the VkQueue.
*
* Queue submission can happen on any thread.
* Even if queue submission happens on the same thread as retro_run(), the lock/unlock
* functions must still be called.
* Even if queue submission happens on the same thread as retro_run(),
* the lock/unlock functions must still be called.
*
* NOTE: Queue submissions are heavy-weight. */
retro_vulkan_lock_queue_t lock_queue;