mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-18 13:20:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Config file/libretro-common) config_file_extract_value - don't make

Browse Source 
it dependent on strldup which pulls in another dependency/source file -
instead just unroll strldup for this specific one-time instance
This commit is contained in:
libretroadmin 2023-02-21 16:37:30 +01:00
parent 8e0e5096d2
commit 51894c3cbb
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libretro-common/file/config_file.c
View File

@ -207,12 +207,13 @@ static char *config_file_strip_comment(char *str)
static char *config_file_extract_value(char *line)
{
char *dst = NULL;
while (ISSPACE((int)*line))
line++;
/* Note: From this point on, an empty value
* string is valid - and in this case, strldup("", sizeof(""))
* will be returned
* will be returned (see Note 2)
* > If we instead return NULL, the the entry
* is ignored completely - which means we cannot
* track *changes* in entry value */
@ -254,7 +255,13 @@ static char *config_file_extract_value(char *line)
return strdup(value);
}
return strldup("", sizeof(""));
/* Note 2: This is an unrolled strldup call
* to avoid an unnecessary dependency -
* call is strldup("", sizeof(""))
**/
dst = (char*)malloc(sizeof(char*) * 2);
strlcpy(dst, "", 1);
return dst;
}
/* Move semantics? */