mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-11 00:44:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

(rmsgpack.c) Fix possible double free() in rmsgpack_read()

Browse Source 
read_buff() didn't set *pbuff to NULL after on error.
This commit is contained in:
Higor Eurípedes 2016-09-17 21:17:52 -03:00
parent 824ded963b
commit 3ec31873e8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libretro-db/rmsgpack.c
View File

@ -122,7 +122,7 @@ int rmsgpack_write_array_header(RFILE *fd, uint32_t size)
if (filestream_write(fd, &MPF_ARRAY32, sizeof(MPF_ARRAY32)) == -1) if (filestream_write(fd, &MPF_ARRAY32, sizeof(MPF_ARRAY32)) == -1)
goto error; goto error;
tmp_i32 = swap_if_little32(size); tmp_i32 = swap_if_little32(size);
if (filestream_write(fd, (void *)(&tmp_i32), sizeof(uint32_t)) == -1) if (filestream_write(fd, (void *)(&tmp_i32), sizeof(uint32_t)) == -1)
@ -247,7 +247,7 @@ int rmsgpack_write_bin(RFILE *fd, const void *s, uint32_t len)
if (filestream_write(fd, &tmp_i32, sizeof(uint32_t)) == -1) if (filestream_write(fd, &tmp_i32, sizeof(uint32_t)) == -1)
goto error; goto error;
} }
if (filestream_write(fd, s, len) == -1) if (filestream_write(fd, s, len) == -1)
goto error; goto error;
@ -482,6 +482,7 @@ static int read_buff(RFILE *fd, size_t size, char **pbuff, uint64_t *len)
error: error:
free(*pbuff); free(*pbuff);
*pbuff = NULL;
return -errno; return -errno;
} }