mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-02-04 12:40:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Terminate recording if resolution changes.

Browse Source 
Simpler this way.
This commit is contained in:
Themaister 2012-08-25 22:48:09 +02:00
parent 304615510a
commit 3681e4a846
1 changed files with 11 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
retroarch.c
View File

@ -189,6 +189,8 @@ static void readjust_audio_input_rate(void)
} }
#ifdef HAVE_FFMPEG #ifdef HAVE_FFMPEG
static void deinit_recording(void);
static void recording_dump_frame(const void *data, unsigned width, unsigned height, size_t pitch) static void recording_dump_frame(const void *data, unsigned width, unsigned height, size_t pitch)
{ {
struct ffemu_video_data ffemu_data = {0}; struct ffemu_video_data ffemu_data = {0};
@ -207,27 +209,17 @@ static void recording_dump_frame(const void *data, unsigned width, unsigned heig
return; return;
} }
// User has resized. We're kinda fucked now, but we just have to go through with it. // User has resized. We're kinda fucked now.
// Resize in ffmpeg if we have to ...
if (gpu_w != g_extern.record_gpu_width || gpu_h != g_extern.record_gpu_height) if (gpu_w != g_extern.record_gpu_width || gpu_h != g_extern.record_gpu_height)
{ {
RARCH_WARN("Resize has taken place. Image quality in recording will now lower dramatically as output is fixed resolution.\n"); static const char msg[] = "Recording terminated due to resize.";
RARCH_WARN("%s\n", msg);
msg_queue_clear(g_extern.msg_queue);
msg_queue_push(g_extern.msg_queue, msg, 1, 180);
uint8_t *new_buffer = (uint8_t*)realloc(g_extern.record_gpu_buffer, gpu_w * gpu_h * 3); deinit_recording();
if (!new_buffer) g_extern.recording = false;
{ return;
RARCH_ERR("Failed to realloce GPU record buffer. Will revert back to raw data. This will probably not work right ...\n");
free(g_extern.record_gpu_buffer);
g_extern.record_gpu_buffer = NULL;
recording_dump_frame(data, width, height, pitch);
return;
}
g_extern.record_gpu_buffer = new_buffer;
g_extern.record_gpu_width = gpu_w;
g_extern.record_gpu_height = gpu_h;
} }
// Big bottleneck. Also adds one frame "delay" to video output as we haven't rendered the current frame yet. // Big bottleneck. Also adds one frame "delay" to video output as we haven't rendered the current frame yet.
@ -1336,6 +1328,7 @@ static void deinit_recording(void)
{ {
ffemu_finalize(g_extern.rec); ffemu_finalize(g_extern.rec);
ffemu_free(g_extern.rec); ffemu_free(g_extern.rec);
g_extern.rec = NULL;
free(g_extern.record_gpu_buffer); free(g_extern.record_gpu_buffer);
g_extern.record_gpu_buffer = NULL; g_extern.record_gpu_buffer = NULL;