mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-01-30 12:32:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

(task_queue.c) Prevent resource leak

Browse Source
This commit is contained in:
twinaphex 2016-06-01 02:37:26 +02:00
parent bedd67a8b8
commit 2e42778f1e
1 changed files with 31 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
libretro-common/queues/task_queue.c
View File

@ -215,42 +215,46 @@ static bool retro_task_regular_find(retro_task_finder_t func, void *user_data)
static void retro_task_regular_retrieve(task_retriever_data_t *data)
{
retro_task_t *task;
task_retriever_info_t *info;
retro_task_t *task = NULL;
task_retriever_info_t *tail = NULL;
/* Parse all running tasks and handle matching handlers */
for (task = tasks_running.front; task != NULL; task = task->next)
if (task->handler == data->handler)
{
task_retriever_info_t *info = NULL;
if (task->handler != data->handler)
continue;
/* Create new link */
info = (task_retriever_info_t*)malloc(sizeof(task_retriever_info_t));
info->data = malloc(data->element_size);
info->next = NULL;
/* Call retriever function and fill info-specific data */
if (!data->func(task, info->data))
{
/* Create new link */
info = (task_retriever_info_t*)malloc(sizeof(task_retriever_info_t));
info->data = malloc(data->element_size);
info->next = NULL;
free(info->data);
free(info);
continue;
}
/* Call retriever function and fill info-specific data */
if (!data->func(task, info->data))
/* Add link to list */
if (data->list)
{
if (tail)
{
free(info->data);
free(info);
continue;
}
/* Add link to list */
if (data->list == NULL)
{
data->list = info;
tail = data->list;
}
else
{
if (tail)
{
tail->next = info;
tail = tail->next;
}
tail->next = info;
tail = tail->next;
}
}
else
{
data->list = info;
tail = data->list;
}
free(info);
}
}
static struct retro_task_impl impl_regular = {