mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-23 01:21:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to use vsnprintf where possible instead of vsprintf

Browse Source
This commit is contained in:
twinaphex 2020-06-26 20:56:14 +02:00
parent 5f607f5809
commit 1b86ea43c3
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libretro-common/streams/file_stream.c
View File

@ -443,7 +443,8 @@ int filestream_putc(RFILE *stream, int c)
int filestream_vprintf(RFILE *stream, const char* format, va_list args) int filestream_vprintf(RFILE *stream, const char* format, va_list args)
{ {
static char buffer[8 * 1024]; static char buffer[8 * 1024];
int64_t num_chars = vsprintf(buffer, format, args); int64_t num_chars = vsnprintf(buffer, sizeof(buffer),
format, args);
if (num_chars < 0) if (num_chars < 0)
return -1; return -1;

3
libretro-common/streams/rzip_stream.c
View File

@ -840,7 +840,8 @@ int rzipstream_putc(rzipstream_t *stream, int c)
int rzipstream_vprintf(rzipstream_t *stream, const char* format, va_list args) int rzipstream_vprintf(rzipstream_t *stream, const char* format, va_list args)
{ {
static char buffer[8 * 1024] = {0}; static char buffer[8 * 1024] = {0};
int64_t num_chars = vsprintf(buffer, format, args); int64_t num_chars = vsnprintf(buffer,
sizeof(buffer), format, args);
if (num_chars < 0) if (num_chars < 0)
return -1; return -1;

6
verbosity.c
View File

@ -258,13 +258,11 @@ void RARCH_LOG_V(const char *tag, const char *fmt, va_list ap)
#else #else
FILE *fp = (FILE*)g_verbosity->fp; FILE *fp = (FILE*)g_verbosity->fp;
#if defined(HAVE_QT) || defined(__WINRT__) #if defined(HAVE_QT) || defined(__WINRT__)
int ret;
char buffer[256]; char buffer[256];
buffer[0] = '\0'; buffer[0] = '\0';
ret = vsnprintf(buffer, sizeof(buffer), fmt, ap);
/* ensure null termination and line break in error case */ /* Ensure null termination and line break in error case */
if (ret < 0) if (vsnprintf(buffer, sizeof(buffer), fmt, ap) < 0)
{ {
int end; int end;
buffer[sizeof(buffer) - 1] = '\0'; buffer[sizeof(buffer) - 1] = '\0';