Make classes which are not extended final. This gives a clear indication of such.

This commit is contained in:
Lioncash 2013-09-27 00:00:51 -04:00
parent 2ead9b328b
commit 14c3892208
24 changed files with 25 additions and 25 deletions

View File

@ -10,7 +10,7 @@ import java.io.PrintWriter;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
public class ConfigFile { public final class ConfigFile {
private HashMap<String, String> map = new HashMap<String, String>(); private HashMap<String, String> map = new HashMap<String, String>();
public void append(InputStream stream) throws IOException { public void append(InputStream stream) throws IOException {

View File

@ -13,7 +13,7 @@ import android.view.*;
// JELLY_BEAN_MR1 = 17 // JELLY_BEAN_MR1 = 17
public class CoreSelection extends Activity implements public final class CoreSelection extends Activity implements
AdapterView.OnItemClickListener { AdapterView.OnItemClickListener {
private IconAdapter<ModuleWrapper> adapter; private IconAdapter<ModuleWrapper> adapter;
static private final String TAG = "CoreSelection"; static private final String TAG = "CoreSelection";

View File

@ -12,7 +12,7 @@ import android.util.Log;
import android.view.WindowManager; import android.view.WindowManager;
import android.widget.Toast; import android.widget.Toast;
public class DisplayRefreshRateTest extends Activity { public final class DisplayRefreshRateTest extends Activity {
private class Renderer implements GLSurfaceView.Renderer { private class Renderer implements GLSurfaceView.Renderer {
private static final String TAG = "GLESRenderer"; private static final String TAG = "GLESRenderer";

View File

@ -6,7 +6,7 @@ import org.retroarch.R;
import android.graphics.drawable.Drawable; import android.graphics.drawable.Drawable;
class FileWrapper implements IconAdapterItem { final class FileWrapper implements IconAdapterItem {
public final File file; public final File file;
public final boolean parentItem; public final boolean parentItem;
public final boolean dirSelectItem; public final boolean dirSelectItem;

View File

@ -6,7 +6,7 @@ import android.os.Bundle;
import android.preference.PreferenceActivity; import android.preference.PreferenceActivity;
import android.preference.PreferenceManager; import android.preference.PreferenceManager;
public class HelpActivity extends PreferenceActivity { public final class HelpActivity extends PreferenceActivity {
@SuppressWarnings("deprecation") @SuppressWarnings("deprecation")
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {

View File

@ -17,7 +17,7 @@ import android.widget.AdapterView;
import android.widget.ListView; import android.widget.ListView;
import android.widget.Toast; import android.widget.Toast;
public class HistorySelection extends Activity implements public final class HistorySelection extends Activity implements
AdapterView.OnItemClickListener { AdapterView.OnItemClickListener {
private IconAdapter<HistoryWrapper> adapter; private IconAdapter<HistoryWrapper> adapter;

View File

@ -4,7 +4,7 @@ import java.io.File;
import android.graphics.drawable.Drawable; import android.graphics.drawable.Drawable;
public class HistoryWrapper implements IconAdapterItem { public final class HistoryWrapper implements IconAdapterItem {
private String gamePath; private String gamePath;
private String gamePathShort; private String gamePathShort;

View File

@ -5,7 +5,7 @@ import android.content.Context;
import android.os.Bundle; import android.os.Bundle;
import android.view.inputmethod.InputMethodManager; import android.view.inputmethod.InputMethodManager;
public class IMEActivity extends Activity { public final class IMEActivity extends Activity {
@Override @Override
protected void onCreate(Bundle savedInstanceState) { protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);

View File

@ -16,7 +16,7 @@ interface IconAdapterItem {
public abstract Drawable getIconDrawable(); public abstract Drawable getIconDrawable();
} }
class IconAdapter<T extends IconAdapterItem> extends ArrayAdapter<T> { final class IconAdapter<T extends IconAdapterItem> extends ArrayAdapter<T> {
private final int layout; private final int layout;
public IconAdapter(Activity aContext, int aLayout) { public IconAdapter(Activity aContext, int aLayout) {

View File

@ -14,7 +14,7 @@ import android.widget.EditText;
import android.widget.ListView; import android.widget.ListView;
import org.retroarch.R; import org.retroarch.R;
class KeyBindEditText extends EditText final class KeyBindEditText extends EditText
{ {
KeyBindPreference pref; KeyBindPreference pref;
public KeyBindEditText(Context context, AttributeSet attrs) { public KeyBindEditText(Context context, AttributeSet attrs) {
@ -39,7 +39,7 @@ class KeyBindEditText extends EditText
} }
} }
class KeyBindPreference extends DialogPreference implements View.OnKeyListener, AdapterView.OnItemClickListener, LayoutInflater.Factory { final class KeyBindPreference extends DialogPreference implements View.OnKeyListener, AdapterView.OnItemClickListener, LayoutInflater.Factory {
private int key_bind_code; private int key_bind_code;
private boolean grabKeyCode = false; private boolean grabKeyCode = false;
KeyBindEditText keyText; KeyBindEditText keyText;

View File

@ -28,7 +28,7 @@ import android.view.Display;
import android.view.WindowManager; import android.view.WindowManager;
import android.widget.Toast; import android.widget.Toast;
public class MainMenuActivity extends PreferenceActivity { public final class MainMenuActivity extends PreferenceActivity {
private static MainMenuActivity instance = null; private static MainMenuActivity instance = null;
static private final int ACTIVITY_LOAD_ROM = 0; static private final int ACTIVITY_LOAD_ROM = 0;
static private final String TAG = "MainMenu"; static private final String TAG = "MainMenu";

View File

@ -6,7 +6,7 @@ import java.io.IOException;
import android.content.Context; import android.content.Context;
import android.graphics.drawable.Drawable; import android.graphics.drawable.Drawable;
class ModuleWrapper implements IconAdapterItem { final class ModuleWrapper implements IconAdapterItem {
public final File file; public final File file;
private ConfigFile config; private ConfigFile config;

View File

@ -4,7 +4,7 @@ import java.io.File;
import android.os.Bundle; import android.os.Bundle;
public class OverlayActivity extends DirectoryActivity { public final class OverlayActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
File overlayDir = new File(getBaseContext().getApplicationInfo().dataDir, "overlays"); File overlayDir = new File(getBaseContext().getApplicationInfo().dataDir, "overlays");

View File

@ -5,7 +5,7 @@ import java.io.File;
import android.content.SharedPreferences; import android.content.SharedPreferences;
import android.os.Bundle; import android.os.Bundle;
public class ROMActivity extends DirectoryActivity { public final class ROMActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {

View File

@ -2,7 +2,7 @@ package org.retroarch.browser;
import android.os.Bundle; import android.os.Bundle;
public class ROMDirActivity extends DirectoryActivity { public final class ROMDirActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.setPathSettingKey("rgui_browser_directory"); super.setPathSettingKey("rgui_browser_directory");

View File

@ -8,7 +8,7 @@ import android.view.Display;
import android.view.WindowManager; import android.view.WindowManager;
import android.widget.Toast; import android.widget.Toast;
public class RefreshRateSetOS extends Activity { public final class RefreshRateSetOS extends Activity {
@Override @Override
protected void onCreate(Bundle savedInstanceState) { protected void onCreate(Bundle savedInstanceState) {

View File

@ -6,7 +6,7 @@ import android.content.DialogInterface;
import android.os.Bundle; import android.os.Bundle;
import android.provider.Settings; import android.provider.Settings;
public class ReportIME extends Activity { public final class ReportIME extends Activity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);

View File

@ -4,7 +4,7 @@ import android.app.NativeActivity;
import android.os.Bundle; import android.os.Bundle;
import android.widget.Toast; import android.widget.Toast;
public class RetroActivity extends NativeActivity { public final class RetroActivity extends NativeActivity {
public RetroActivity() { public RetroActivity() {
super(); super();
} }

View File

@ -5,7 +5,7 @@ import android.content.Intent;
import android.os.Bundle; import android.os.Bundle;
import android.provider.Settings; import android.provider.Settings;
public class RetroTVMode extends Activity { public final class RetroTVMode extends Activity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {

View File

@ -2,7 +2,7 @@ package org.retroarch.browser;
import android.os.Bundle; import android.os.Bundle;
public class SRMDirActivity extends DirectoryActivity { public final class SRMDirActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.setPathSettingKey("savefile_directory"); super.setPathSettingKey("savefile_directory");

View File

@ -10,7 +10,7 @@ import android.view.View;
import android.widget.SeekBar; import android.widget.SeekBar;
import android.widget.TextView; import android.widget.TextView;
public class SeekbarPreference extends DialogPreference implements SeekBar.OnSeekBarChangeListener { public final class SeekbarPreference extends DialogPreference implements SeekBar.OnSeekBarChangeListener {
float seek_value; float seek_value;
SeekBar bar; SeekBar bar;
TextView text; TextView text;

View File

@ -4,7 +4,7 @@ import java.io.File;
import android.os.Bundle; import android.os.Bundle;
public class ShaderActivity extends DirectoryActivity { public final class ShaderActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
File shaderDir = new File(getBaseContext().getApplicationInfo().dataDir, "shaders_glsl"); File shaderDir = new File(getBaseContext().getApplicationInfo().dataDir, "shaders_glsl");

View File

@ -2,7 +2,7 @@ package org.retroarch.browser;
import android.os.Bundle; import android.os.Bundle;
public class StateDirActivity extends DirectoryActivity { public final class StateDirActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.setPathSettingKey("savestate_directory"); super.setPathSettingKey("savestate_directory");

View File

@ -2,7 +2,7 @@ package org.retroarch.browser;
import android.os.Bundle; import android.os.Bundle;
public class SystemDirActivity extends DirectoryActivity { public final class SystemDirActivity extends DirectoryActivity {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.setPathSettingKey("system_directory"); super.setPathSettingKey("system_directory");