mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-04-16 17:43:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

(playlist.c) Turn this code more robust

Browse Source
This commit is contained in:
twinaphex 2017-05-29 20:36:18 +02:00
parent 1cdd0e47cb
commit 0bd74c923f
1 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
playlist.c
View File

@ -149,28 +149,24 @@ static void playlist_free_entry(struct playlist_entry *entry)
if (!entry) if (!entry)
return; return;
if (!string_is_empty(entry->path)) if (entry->path != NULL)
free(entry->path); free(entry->path);
entry->path = NULL; if (entry->label != NULL)
if (!string_is_empty(entry->label))
free(entry->label); free(entry->label);
entry->label = NULL; if (entry->core_path != NULL)
if (!string_is_empty(entry->core_path))
free(entry->core_path); free(entry->core_path);
entry->core_path = NULL; if (entry->core_name != NULL)
if (!string_is_empty(entry->core_name))
free(entry->core_name); free(entry->core_name);
entry->core_name = NULL; if (entry->db_name != NULL)
if (!string_is_empty(entry->db_name))
free(entry->db_name); free(entry->db_name);
entry->db_name = NULL; if (entry->crc32 != NULL)
if (!string_is_empty(entry->crc32))
free(entry->crc32); free(entry->crc32);
entry->path = NULL;
entry->label = NULL;
entry->core_path = NULL;
entry->core_name = NULL;
entry->db_name = NULL;
entry->crc32 = NULL; entry->crc32 = NULL;
} }
@ -189,42 +185,54 @@ void playlist_update(playlist_t *playlist, size_t idx,
if (path && (path != entry->path)) if (path && (path != entry->path))
{ {
if (entry->path != NULL)
free(entry->path); free(entry->path);
entry->path = NULL;
entry->path = strdup(path); entry->path = strdup(path);
playlist->modified = true; playlist->modified = true;
} }
if (label && (label != entry->label)) if (label && (label != entry->label))
{ {
if (entry->label != NULL)
free(entry->label); free(entry->label);
entry->label = NULL;
entry->label = strdup(label); entry->label = strdup(label);
playlist->modified = true; playlist->modified = true;
} }
if (core_path && (core_path != entry->core_path)) if (core_path && (core_path != entry->core_path))
{ {
if (entry->core_path != NULL)
free(entry->core_path); free(entry->core_path);
entry->core_path = NULL;
entry->core_path = strdup(core_path); entry->core_path = strdup(core_path);
playlist->modified = true; playlist->modified = true;
} }
if (core_name && (core_name != entry->core_name)) if (core_name && (core_name != entry->core_name))
{ {
if (entry->core_name != NULL)
free(entry->core_name); free(entry->core_name);
entry->core_name = NULL;
entry->core_name = strdup(core_name); entry->core_name = strdup(core_name);
playlist->modified = true; playlist->modified = true;
} }
if (db_name && (db_name != entry->db_name)) if (db_name && (db_name != entry->db_name))
{ {
if (entry->db_name != NULL)
free(entry->db_name); free(entry->db_name);
entry->db_name = NULL;
entry->db_name = strdup(db_name); entry->db_name = strdup(db_name);
playlist->modified = true; playlist->modified = true;
} }
if (crc32 && (crc32 != entry->crc32)) if (crc32 && (crc32 != entry->crc32))
{ {
if (entry->crc32 != NULL)
free(entry->crc32); free(entry->crc32);
entry->crc32 = NULL;
entry->crc32 = strdup(crc32); entry->crc32 = strdup(crc32);
playlist->modified = true; playlist->modified = true;
} }