From c9c32d9a0de9388e1e5cb9c4a0729b44d7d938bc Mon Sep 17 00:00:00 2001 From: elsid Date: Fri, 28 Jul 2023 15:23:53 +0200 Subject: [PATCH 1/2] Cleanup includes --- apps/openmw/mwgui/charactercreation.cpp | 2 +- apps/openmw/mwgui/inventoryitemmodel.cpp | 3 +-- apps/openmw/mwgui/inventorywindow.cpp | 2 +- apps/openmw/mwgui/itemmodel.cpp | 3 --- apps/openmw/mwgui/repair.cpp | 3 +-- apps/openmw/mwgui/sortfilteritemmodel.cpp | 7 ++++--- apps/openmw/mwinput/controllermanager.cpp | 5 +---- apps/openmw/mwinput/controllermanager.hpp | 3 ++- apps/openmw/mwlua/cellbindings.cpp | 1 + apps/openmw/mwlua/luamanagerimp.cpp | 1 + apps/openmw/mwlua/mwscriptbindings.cpp | 7 ++++++- apps/openmw/mwlua/object.hpp | 3 +-- apps/openmw/mwlua/objectbindings.cpp | 1 + apps/openmw/mwlua/types/actor.cpp | 13 +++++++------ apps/openmw/mwlua/types/door.cpp | 3 ++- apps/openmw/mwscript/cellextensions.cpp | 7 +++---- apps/openmw/mwscript/dialogueextensions.cpp | 2 +- apps/openmw/mwscript/guiextensions.cpp | 3 +-- apps/openmw/mwscript/skyextensions.cpp | 3 +-- components/fx/widgets.hpp | 4 ++-- 20 files changed, 38 insertions(+), 38 deletions(-) diff --git a/apps/openmw/mwgui/charactercreation.cpp b/apps/openmw/mwgui/charactercreation.cpp index 090025d2d7..bd7706c8b1 100644 --- a/apps/openmw/mwgui/charactercreation.cpp +++ b/apps/openmw/mwgui/charactercreation.cpp @@ -13,7 +13,7 @@ #include "../mwbase/world.hpp" #include "../mwmechanics/actorutil.hpp" -#include "../mwmechanics/npcstats.hpp" +#include "../mwmechanics/creaturestats.hpp" #include "../mwworld/class.hpp" #include "../mwworld/esmstore.hpp" diff --git a/apps/openmw/mwgui/inventoryitemmodel.cpp b/apps/openmw/mwgui/inventoryitemmodel.cpp index e87ae7b8e0..e20637d58c 100644 --- a/apps/openmw/mwgui/inventoryitemmodel.cpp +++ b/apps/openmw/mwgui/inventoryitemmodel.cpp @@ -3,12 +3,11 @@ #include #include "../mwmechanics/actorutil.hpp" -#include "../mwmechanics/npcstats.hpp" +#include "../mwmechanics/creaturestats.hpp" #include "../mwworld/class.hpp" #include "../mwworld/containerstore.hpp" #include "../mwworld/inventorystore.hpp" -#include "../mwworld/manualref.hpp" #include "../mwbase/environment.hpp" #include "../mwbase/mechanicsmanager.hpp" diff --git a/apps/openmw/mwgui/inventorywindow.cpp b/apps/openmw/mwgui/inventorywindow.cpp index 2ef0406e3a..9ae9ecf2b0 100644 --- a/apps/openmw/mwgui/inventorywindow.cpp +++ b/apps/openmw/mwgui/inventorywindow.cpp @@ -23,7 +23,7 @@ #include "../mwbase/windowmanager.hpp" #include "../mwbase/world.hpp" -#include "../mwworld/actionequip.hpp" +#include "../mwworld/action.hpp" #include "../mwworld/class.hpp" #include "../mwworld/inventorystore.hpp" diff --git a/apps/openmw/mwgui/itemmodel.cpp b/apps/openmw/mwgui/itemmodel.cpp index fce3e68e78..4bdd2399fe 100644 --- a/apps/openmw/mwgui/itemmodel.cpp +++ b/apps/openmw/mwgui/itemmodel.cpp @@ -2,13 +2,10 @@ #include "../mwworld/class.hpp" #include "../mwworld/containerstore.hpp" -#include "../mwworld/worldmodel.hpp" #include "../mwbase/environment.hpp" #include "../mwbase/mechanicsmanager.hpp" -#include - namespace MWGui { diff --git a/apps/openmw/mwgui/repair.cpp b/apps/openmw/mwgui/repair.cpp index dc559f03b0..12f04a15d8 100644 --- a/apps/openmw/mwgui/repair.cpp +++ b/apps/openmw/mwgui/repair.cpp @@ -4,16 +4,15 @@ #include +#include #include #include "../mwbase/environment.hpp" #include "../mwbase/windowmanager.hpp" -#include "../mwbase/world.hpp" #include "../mwmechanics/actorutil.hpp" #include "../mwworld/class.hpp" -#include "../mwworld/containerstore.hpp" #include "inventoryitemmodel.hpp" #include "itemchargeview.hpp" diff --git a/apps/openmw/mwgui/sortfilteritemmodel.cpp b/apps/openmw/mwgui/sortfilteritemmodel.cpp index 81074d7fcf..4a5e02a881 100644 --- a/apps/openmw/mwgui/sortfilteritemmodel.cpp +++ b/apps/openmw/mwgui/sortfilteritemmodel.cpp @@ -1,7 +1,5 @@ #include "sortfilteritemmodel.hpp" -#include "../mwbase/environment.hpp" -#include "../mwbase/world.hpp" #include #include #include @@ -19,9 +17,12 @@ #include #include +#include "../mwbase/environment.hpp" +#include "../mwbase/world.hpp" + +#include "../mwworld/action.hpp" #include "../mwworld/class.hpp" #include "../mwworld/esmstore.hpp" -#include "../mwworld/nullaction.hpp" #include "../mwmechanics/alchemy.hpp" #include "../mwmechanics/spellutil.hpp" diff --git a/apps/openmw/mwinput/controllermanager.cpp b/apps/openmw/mwinput/controllermanager.cpp index 0fc625ccc1..7054f72c8f 100644 --- a/apps/openmw/mwinput/controllermanager.cpp +++ b/apps/openmw/mwinput/controllermanager.cpp @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -15,11 +16,7 @@ #include "../mwbase/luamanager.hpp" #include "../mwbase/statemanager.hpp" #include "../mwbase/windowmanager.hpp" -#include "../mwbase/world.hpp" -#include "../mwworld/player.hpp" - -#include "actionmanager.hpp" #include "actions.hpp" #include "bindingsmanager.hpp" #include "mousemanager.hpp" diff --git a/apps/openmw/mwinput/controllermanager.hpp b/apps/openmw/mwinput/controllermanager.hpp index 63bfc07169..596a9ef465 100644 --- a/apps/openmw/mwinput/controllermanager.hpp +++ b/apps/openmw/mwinput/controllermanager.hpp @@ -1,11 +1,12 @@ #ifndef MWINPUT_MWCONTROLLERMANAGER_H #define MWINPUT_MWCONTROLLERMANAGER_H +#include +#include #include #include #include -#include namespace MWInput { diff --git a/apps/openmw/mwlua/cellbindings.cpp b/apps/openmw/mwlua/cellbindings.cpp index 914f3f5fcc..51f5bb25f5 100644 --- a/apps/openmw/mwlua/cellbindings.cpp +++ b/apps/openmw/mwlua/cellbindings.cpp @@ -4,6 +4,7 @@ #include #include "../mwworld/cellstore.hpp" +#include "../mwworld/worldmodel.hpp" #include "types/types.hpp" diff --git a/apps/openmw/mwlua/luamanagerimp.cpp b/apps/openmw/mwlua/luamanagerimp.cpp index f7386ca61d..326afbb4ad 100644 --- a/apps/openmw/mwlua/luamanagerimp.cpp +++ b/apps/openmw/mwlua/luamanagerimp.cpp @@ -26,6 +26,7 @@ #include "../mwworld/esmstore.hpp" #include "../mwworld/ptr.hpp" #include "../mwworld/scene.hpp" +#include "../mwworld/worldmodel.hpp" #include "luabindings.hpp" #include "playerscripts.hpp" diff --git a/apps/openmw/mwlua/mwscriptbindings.cpp b/apps/openmw/mwlua/mwscriptbindings.cpp index 2b91d0d04f..dbe02a9fed 100644 --- a/apps/openmw/mwlua/mwscriptbindings.cpp +++ b/apps/openmw/mwlua/mwscriptbindings.cpp @@ -1,12 +1,17 @@ #include "mwscriptbindings.hpp" #include +#include +#include "../mwbase/environment.hpp" +#include "../mwbase/scriptmanager.hpp" #include "../mwbase/world.hpp" -#include "../mwscript/scriptmanagerimp.hpp" +#include "../mwscript/globalscripts.hpp" #include "object.hpp" +#include + namespace MWLua { struct MWScriptRef diff --git a/apps/openmw/mwlua/object.hpp b/apps/openmw/mwlua/object.hpp index 89bf425295..fcf225de85 100644 --- a/apps/openmw/mwlua/object.hpp +++ b/apps/openmw/mwlua/object.hpp @@ -2,15 +2,14 @@ #define MWLUA_OBJECT_H #include +#include #include #include #include -#include "../mwbase/environment.hpp" #include "../mwworld/ptr.hpp" -#include "../mwworld/worldmodel.hpp" namespace MWLua { diff --git a/apps/openmw/mwlua/objectbindings.cpp b/apps/openmw/mwlua/objectbindings.cpp index 7c0606b1d1..cbd8347d0d 100644 --- a/apps/openmw/mwlua/objectbindings.cpp +++ b/apps/openmw/mwlua/objectbindings.cpp @@ -13,6 +13,7 @@ #include "../mwworld/containerstore.hpp" #include "../mwworld/player.hpp" #include "../mwworld/scene.hpp" +#include "../mwworld/worldmodel.hpp" #include "../mwrender/renderingmanager.hpp" diff --git a/apps/openmw/mwlua/types/actor.cpp b/apps/openmw/mwlua/types/actor.cpp index 641723afe9..199bc3bd08 100644 --- a/apps/openmw/mwlua/types/actor.cpp +++ b/apps/openmw/mwlua/types/actor.cpp @@ -3,12 +3,13 @@ #include #include -#include -#include -#include -#include -#include -#include +#include "apps/openmw/mwbase/mechanicsmanager.hpp" +#include "apps/openmw/mwbase/windowmanager.hpp" +#include "apps/openmw/mwmechanics/creaturestats.hpp" +#include "apps/openmw/mwmechanics/drawstate.hpp" +#include "apps/openmw/mwworld/class.hpp" +#include "apps/openmw/mwworld/inventorystore.hpp" +#include "apps/openmw/mwworld/worldmodel.hpp" #include "../localscripts.hpp" #include "../luamanagerimp.hpp" diff --git a/apps/openmw/mwlua/types/door.cpp b/apps/openmw/mwlua/types/door.cpp index 4505f2db7e..3f1e77f629 100644 --- a/apps/openmw/mwlua/types/door.cpp +++ b/apps/openmw/mwlua/types/door.cpp @@ -7,7 +7,8 @@ #include #include -#include +#include "apps/openmw/mwworld/esmstore.hpp" +#include "apps/openmw/mwworld/worldmodel.hpp" namespace sol { diff --git a/apps/openmw/mwscript/cellextensions.cpp b/apps/openmw/mwscript/cellextensions.cpp index 9ffc3f7bec..3a8318a7a3 100644 --- a/apps/openmw/mwscript/cellextensions.cpp +++ b/apps/openmw/mwscript/cellextensions.cpp @@ -2,14 +2,15 @@ #include -#include "../mwworld/esmstore.hpp" - #include +#include #include #include #include +#include + #include "../mwbase/environment.hpp" #include "../mwbase/statemanager.hpp" #include "../mwbase/windowmanager.hpp" @@ -20,8 +21,6 @@ #include "../mwmechanics/actorutil.hpp" -#include "interpretercontext.hpp" - namespace MWScript { namespace Cell diff --git a/apps/openmw/mwscript/dialogueextensions.cpp b/apps/openmw/mwscript/dialogueextensions.cpp index 857f3c5edf..5a361e1bdc 100644 --- a/apps/openmw/mwscript/dialogueextensions.cpp +++ b/apps/openmw/mwscript/dialogueextensions.cpp @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -16,7 +17,6 @@ #include "../mwmechanics/npcstats.hpp" #include "../mwworld/class.hpp" -#include "interpretercontext.hpp" #include "ref.hpp" namespace MWScript diff --git a/apps/openmw/mwscript/guiextensions.cpp b/apps/openmw/mwscript/guiextensions.cpp index b2667e6320..c1590941e6 100644 --- a/apps/openmw/mwscript/guiextensions.cpp +++ b/apps/openmw/mwscript/guiextensions.cpp @@ -2,6 +2,7 @@ #include +#include #include #include #include @@ -11,11 +12,9 @@ #include "../mwbase/environment.hpp" #include "../mwbase/mechanicsmanager.hpp" #include "../mwbase/windowmanager.hpp" -#include "../mwbase/world.hpp" #include "../mwmechanics/actorutil.hpp" -#include "interpretercontext.hpp" #include "ref.hpp" namespace MWScript diff --git a/apps/openmw/mwscript/skyextensions.cpp b/apps/openmw/mwscript/skyextensions.cpp index 2284e2a3ae..39944970bf 100644 --- a/apps/openmw/mwscript/skyextensions.cpp +++ b/apps/openmw/mwscript/skyextensions.cpp @@ -5,6 +5,7 @@ #include #include +#include #include #include #include @@ -14,8 +15,6 @@ #include "../mwworld/esmstore.hpp" -#include "interpretercontext.hpp" - namespace MWScript { namespace Sky diff --git a/components/fx/widgets.hpp b/components/fx/widgets.hpp index f02b88f802..baee2d6df4 100644 --- a/components/fx/widgets.hpp +++ b/components/fx/widgets.hpp @@ -10,8 +10,6 @@ #include #include -#include -#include #include #include #include @@ -20,6 +18,8 @@ #include #include +#include + #include "types.hpp" namespace Gui From dd5485761008fd1e3d5b5e3b19e84cc86ed87f84 Mon Sep 17 00:00:00 2001 From: elsid Date: Sat, 29 Jul 2023 00:29:03 +0200 Subject: [PATCH 2/2] Add missing array include --- apps/opencs_tests/model/world/testuniversalid.cpp | 1 + apps/openmw/mwlua/types/actor.cpp | 2 ++ apps/openmw/mwmechanics/actors.cpp | 1 + apps/openmw/mwmechanics/spelleffects.cpp | 1 + apps/openmw/mwrender/skyutil.cpp | 1 + apps/openmw/mwworld/cellpreloader.cpp | 1 + apps/openmw_test_suite/files/hash.cpp | 1 + components/esm3/esmreader.hpp | 1 + components/files/windowspath.cpp | 1 + components/nif/nifstream.hpp | 1 + components/nif/physics.cpp | 2 ++ components/resource/keyframemanager.cpp | 2 ++ components/resource/scenemanager.hpp | 1 + components/sceneutil/depth.cpp | 1 + components/serialization/format.hpp | 1 + components/std140/ubo.hpp | 1 + 16 files changed, 19 insertions(+) diff --git a/apps/opencs_tests/model/world/testuniversalid.cpp b/apps/opencs_tests/model/world/testuniversalid.cpp index 564d65a1ac..2e610b0dd0 100644 --- a/apps/opencs_tests/model/world/testuniversalid.cpp +++ b/apps/opencs_tests/model/world/testuniversalid.cpp @@ -3,6 +3,7 @@ #include #include +#include #include namespace CSMWorld diff --git a/apps/openmw/mwlua/types/actor.cpp b/apps/openmw/mwlua/types/actor.cpp index 199bc3bd08..08fd98c41c 100644 --- a/apps/openmw/mwlua/types/actor.cpp +++ b/apps/openmw/mwlua/types/actor.cpp @@ -1,5 +1,7 @@ #include "types.hpp" +#include + #include #include diff --git a/apps/openmw/mwmechanics/actors.cpp b/apps/openmw/mwmechanics/actors.cpp index afdf1113aa..8c749190f0 100644 --- a/apps/openmw/mwmechanics/actors.cpp +++ b/apps/openmw/mwmechanics/actors.cpp @@ -1,5 +1,6 @@ #include "actors.hpp" +#include #include #include diff --git a/apps/openmw/mwmechanics/spelleffects.cpp b/apps/openmw/mwmechanics/spelleffects.cpp index 89dff6443c..ea2f2a5267 100644 --- a/apps/openmw/mwmechanics/spelleffects.cpp +++ b/apps/openmw/mwmechanics/spelleffects.cpp @@ -1,6 +1,7 @@ #include "spelleffects.hpp" #include +#include #include #include diff --git a/apps/openmw/mwrender/skyutil.cpp b/apps/openmw/mwrender/skyutil.cpp index 2a21b950eb..4c789907ec 100644 --- a/apps/openmw/mwrender/skyutil.cpp +++ b/apps/openmw/mwrender/skyutil.cpp @@ -1,5 +1,6 @@ #include "skyutil.hpp" +#include #include #include diff --git a/apps/openmw/mwworld/cellpreloader.cpp b/apps/openmw/mwworld/cellpreloader.cpp index 2d6a4e2736..e7d2a322c5 100644 --- a/apps/openmw/mwworld/cellpreloader.cpp +++ b/apps/openmw/mwworld/cellpreloader.cpp @@ -1,5 +1,6 @@ #include "cellpreloader.hpp" +#include #include #include diff --git a/apps/openmw_test_suite/files/hash.cpp b/apps/openmw_test_suite/files/hash.cpp index 475d166052..6ad19713dc 100644 --- a/apps/openmw_test_suite/files/hash.cpp +++ b/apps/openmw_test_suite/files/hash.cpp @@ -5,6 +5,7 @@ #include #include +#include #include #include #include diff --git a/components/esm3/esmreader.hpp b/components/esm3/esmreader.hpp index bab11a9fb1..51b8298633 100644 --- a/components/esm3/esmreader.hpp +++ b/components/esm3/esmreader.hpp @@ -1,6 +1,7 @@ #ifndef OPENMW_ESM_READER_H #define OPENMW_ESM_READER_H +#include #include #include #include diff --git a/components/files/windowspath.cpp b/components/files/windowspath.cpp index 0e99e04673..9be3d13a46 100644 --- a/components/files/windowspath.cpp +++ b/components/files/windowspath.cpp @@ -2,6 +2,7 @@ #if defined(_WIN32) || defined(__WINDOWS__) +#include #include #define FAR diff --git a/components/nif/nifstream.hpp b/components/nif/nifstream.hpp index 0fc1cee608..5636489035 100644 --- a/components/nif/nifstream.hpp +++ b/components/nif/nifstream.hpp @@ -3,6 +3,7 @@ #ifndef OPENMW_COMPONENTS_NIF_NIFSTREAM_HPP #define OPENMW_COMPONENTS_NIF_NIFSTREAM_HPP +#include #include #include #include diff --git a/components/nif/physics.cpp b/components/nif/physics.cpp index b2fb12bccf..450f5588cb 100644 --- a/components/nif/physics.cpp +++ b/components/nif/physics.cpp @@ -3,6 +3,8 @@ #include "data.hpp" #include "node.hpp" +#include + namespace Nif { diff --git a/components/resource/keyframemanager.cpp b/components/resource/keyframemanager.cpp index a8d345be53..1519047155 100644 --- a/components/resource/keyframemanager.cpp +++ b/components/resource/keyframemanager.cpp @@ -1,5 +1,7 @@ #include "keyframemanager.hpp" +#include + #include #include diff --git a/components/resource/scenemanager.hpp b/components/resource/scenemanager.hpp index 3648cdfa27..54643b561d 100644 --- a/components/resource/scenemanager.hpp +++ b/components/resource/scenemanager.hpp @@ -1,6 +1,7 @@ #ifndef OPENMW_COMPONENTS_RESOURCE_SCENEMANAGER_H #define OPENMW_COMPONENTS_RESOURCE_SCENEMANAGER_H +#include #include #include #include diff --git a/components/sceneutil/depth.cpp b/components/sceneutil/depth.cpp index ff623f3786..738fa93dd8 100644 --- a/components/sceneutil/depth.cpp +++ b/components/sceneutil/depth.cpp @@ -1,6 +1,7 @@ #include "depth.hpp" #include +#include #include #include diff --git a/components/serialization/format.hpp b/components/serialization/format.hpp index 9197ef13c3..17cd32ccc0 100644 --- a/components/serialization/format.hpp +++ b/components/serialization/format.hpp @@ -2,6 +2,7 @@ #define OPENMW_COMPONENTS_SERIALIZATION_FORMAT_H #include +#include #include #include #include diff --git a/components/std140/ubo.hpp b/components/std140/ubo.hpp index d9f31dd056..f000307a1c 100644 --- a/components/std140/ubo.hpp +++ b/components/std140/ubo.hpp @@ -5,6 +5,7 @@ #include #include +#include #include #include #include