mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-04-01 04:20:20 +00:00
Code Issues Projects Releases Wiki Activity

Cleanup(CS): Pass const ref when applicable for selection groups

Browse Source
This commit is contained in:
Dave Corley 2024-01-05 19:36:51 -06:00
parent 3ff1bae372
commit c563219b61
9 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/opencs/view/render/cell.cpp
View File

@ -612,7 +612,7 @@ osg::ref_ptr<CSVRender::TagBase> CSVRender::Cell::getSnapTarget(unsigned int ele
return result;
}
void CSVRender::Cell::selectFromGroup(const std::vector<std::string> group)
void CSVRender::Cell::selectFromGroup(const std::vector<std::string>& group)
{
for (const auto& [_, object] : mObjects)
{

2
apps/opencs/view/render/cell.hpp
View File

@ -148,7 +148,7 @@ namespace CSVRender
// already selected
void selectAllWithSameParentId(int elementMask);
void selectFromGroup(const std::vector<std::string> group);
void selectFromGroup(const std::vector<std::string>& group);
void unhideAll();

2
apps/opencs/view/render/object.cpp
View File

@ -484,7 +484,7 @@ CSVRender::Object::~Object()
mParentNode->removeChild(mRootNode);
}
void CSVRender::Object::setSelected(bool selected, osg::Vec4f color)
void CSVRender::Object::setSelected(bool selected, const osg::Vec4f& color)
{
mSelected = selected;

2
apps/opencs/view/render/object.hpp
View File

@ -139,7 +139,7 @@ namespace CSVRender
~Object();
/// Mark the object as selected, selected objects show an outline effect
void setSelected(bool selected, osg::Vec4f color = osg::Vec4f(1, 1, 1, 1));
void setSelected(bool selected, const osg::Vec4f& color = osg::Vec4f(1, 1, 1, 1));
bool getSelected() const;

2
apps/opencs/view/render/pagedworldspacewidget.cpp
View File

@ -875,7 +875,7 @@ std::vector<osg::ref_ptr<CSVRender::TagBase>> CSVRender::PagedWorldspaceWidget::
return result;
}
void CSVRender::PagedWorldspaceWidget::selectGroup(std::vector<std::string> group) const
void CSVRender::PagedWorldspaceWidget::selectGroup(const std::vector<std::string>& group) const
{
for (const auto& [_, cell] : mCells)
cell->selectFromGroup(group);

2
apps/opencs/view/render/pagedworldspacewidget.hpp
View File

@ -163,7 +163,7 @@ namespace CSVRender
std::vector<osg::ref_ptr<TagBase>> getSelection(unsigned int elementMask) const override;
void selectGroup(const std::vector<std::string> group) const override;
void selectGroup(const std::vector<std::string>& group) const override;
void unhideAll() const override;

2
apps/opencs/view/render/unpagedworldspacewidget.cpp
View File

@ -199,7 +199,7 @@ std::vector<osg::ref_ptr<CSVRender::TagBase>> CSVRender::UnpagedWorldspaceWidget
return mCell->getSelection(elementMask);
}
void CSVRender::UnpagedWorldspaceWidget::selectGroup(const std::vector<std::string> group) const
void CSVRender::UnpagedWorldspaceWidget::selectGroup(const std::vector<std::string>& group) const
{
mCell->selectFromGroup(group);
}

2
apps/opencs/view/render/unpagedworldspacewidget.hpp
View File

@ -93,7 +93,7 @@ namespace CSVRender
std::vector<osg::ref_ptr<TagBase>> getSelection(unsigned int elementMask) const override;
void selectGroup(const std::vector<std::string> group) const override;
void selectGroup(const std::vector<std::string>& group) const override;
void unhideAll() const override;

2
apps/opencs/view/render/worldspacewidget.hpp
View File

@ -201,7 +201,7 @@ namespace CSVRender
virtual std::vector<osg::ref_ptr<TagBase>> getSelection(unsigned int elementMask) const = 0;
virtual void selectGroup(const std::vector<std::string>) const = 0;
virtual void selectGroup(const std::vector<std::string>&) const = 0;
virtual void unhideAll() const = 0;