mirror of
https://gitlab.com/OpenMW/openmw.git
synced 2025-01-26 18:35:20 +00:00
Correctly handle disjoint pathgrid (Fixes #2871)
Bugfix: When 1. Cell has multiple subgrids (i.e. path grid is disjoint) 2. Distance between destination and pathgrid point 0 is less than distance to points of subgrid closest to start point Then getClosestReachablePoint() returns pathgrid point 0 as the end point. This is invalid, this end point cannot be reached from the start point.
This commit is contained in:
parent
ba79d31929
commit
c0d3804b4f
@ -53,7 +53,8 @@ namespace
|
||||
{
|
||||
assert(grid && !grid->mPoints.empty());
|
||||
|
||||
float distanceBetween = distanceSquared(grid->mPoints[0], pos);
|
||||
float closestDistanceBetween = distanceSquared(grid->mPoints[0], pos);
|
||||
float closestDistanceReachable = closestDistanceBetween;
|
||||
int closestIndex = 0;
|
||||
int closestReachableIndex = 0;
|
||||
// TODO: if this full scan causes performance problems mapping pathgrid
|
||||
@ -61,17 +62,25 @@ namespace
|
||||
for(unsigned int counter = 1; counter < grid->mPoints.size(); counter++)
|
||||
{
|
||||
float potentialDistBetween = distanceSquared(grid->mPoints[counter], pos);
|
||||
if(potentialDistBetween < distanceBetween)
|
||||
if (potentialDistBetween < closestDistanceReachable)
|
||||
{
|
||||
// found a closer one
|
||||
distanceBetween = potentialDistBetween;
|
||||
closestIndex = counter;
|
||||
if (cell->isPointConnected(start, counter))
|
||||
{
|
||||
closestDistanceReachable = potentialDistBetween;
|
||||
closestReachableIndex = counter;
|
||||
}
|
||||
if (potentialDistBetween < closestDistanceBetween)
|
||||
{
|
||||
closestDistanceBetween = potentialDistBetween;
|
||||
closestIndex = counter;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// invariant: start and endpoint must be connected
|
||||
assert(cell->isPointConnected(start, closestReachableIndex));
|
||||
|
||||
// AiWander has logic that depends on whether a path was created, deleting
|
||||
// allowed nodes if not. Hence a path needs to be created even if the start
|
||||
// and the end points are the same.
|
||||
|
Loading…
x
Reference in New Issue
Block a user