mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-02-06 18:40:23 +00:00
Code Issues Projects Releases Wiki Activity

Optimize lookup for a file in the BSA archive

Browse Source 
Use binary search in sorted vector or normalized paths instead of linear search
in the original file struct. With number of files from 1k to 10k in vanilla
archives this gives some benefits.
This commit is contained in:
elsid 2024-01-30 00:46:38 +01:00
parent a297a0e742
commit a2345194c8
No known key found for this signature in database
GPG Key ID: 4DE04C198CBA7625
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
components/vfs/bsaarchive.hpp
View File

@ -10,6 +10,8 @@
#include <components/bsa/bsa_file.hpp>
#include <components/bsa/compressedbsafile.hpp>
#include <algorithm>
namespace VFS
{
template <typename FileType>
@ -44,7 +46,10 @@ namespace VFS
for (Bsa::BSAFile::FileList::const_iterator it = filelist.begin(); it != filelist.end(); ++it)
{
mResources.emplace_back(&*it, mFile.get());
mFiles.emplace_back(it->name());
}
std::sort(mFiles.begin(), mFiles.end());
}
virtual ~BsaArchive() {}
@ -57,12 +62,7 @@ namespace VFS
bool contains(Path::NormalizedView file) const override
{
for (const auto& it : mResources)
{
if (Path::pathEqual(file.value(), it.mInfo->name()))
return true;
}
return false;
return std::binary_search(mFiles.begin(), mFiles.end(), file);
}
std::string getDescription() const override { return std::string{ "BSA: " } + mFile->getFilename(); }
@ -70,6 +70,7 @@ namespace VFS
private:
std::unique_ptr<BSAFileType> mFile;
std::vector<BsaArchiveFile<BSAFileType>> mResources;
std::vector<VFS::Path::Normalized> mFiles;
};
template <Bsa::BsaVersion>