diff --git a/apps/openmw/mwclass/door.cpp b/apps/openmw/mwclass/door.cpp index f2d79a0a3e..cd20398698 100644 --- a/apps/openmw/mwclass/door.cpp +++ b/apps/openmw/mwclass/door.cpp @@ -34,7 +34,7 @@ namespace MWClass class DoorCustomData : public MWWorld::CustomData { public: - MWWorld::DoorState mDoorState; + MWWorld::DoorState mDoorState = MWWorld::DoorState::Idle; virtual MWWorld::CustomData *clone() const; @@ -344,8 +344,6 @@ namespace MWClass if (!ptr.getRefData().getCustomData()) { std::unique_ptr data(new DoorCustomData); - - data->mDoorState = MWWorld::DoorState::Idle; ptr.getRefData().setCustomData(data.release()); } } diff --git a/components/esm/doorstate.cpp b/components/esm/doorstate.cpp index 0487be7a4d..4378bb2197 100644 --- a/components/esm/doorstate.cpp +++ b/components/esm/doorstate.cpp @@ -3,6 +3,8 @@ #include "esmreader.hpp" #include "esmwriter.hpp" +#include + namespace ESM { @@ -12,12 +14,20 @@ namespace ESM mDoorState = 0; esm.getHNOT (mDoorState, "ANIM"); + if (mDoorState < 0 || mDoorState > 2) + Log(Debug::Warning) << "Dropping invalid door state (" << mDoorState << ") for door \"" << mRef.mRefID << "\""; } void DoorState::save(ESMWriter &esm, bool inInventory) const { ObjectState::save(esm, inInventory); + if (mDoorState < 0 || mDoorState > 2) + { + Log(Debug::Warning) << "Dropping invalid door state (" << mDoorState << ") for door \"" << mRef.mRefID << "\""; + return; + } + if (mDoorState != 0) esm.writeHNT ("ANIM", mDoorState); } diff --git a/components/esm/doorstate.hpp b/components/esm/doorstate.hpp index 0df30afb00..c2e7658809 100644 --- a/components/esm/doorstate.hpp +++ b/components/esm/doorstate.hpp @@ -9,7 +9,7 @@ namespace ESM struct DoorState : public ObjectState { - int mDoorState; + int mDoorState = 0; virtual void load (ESMReader &esm); virtual void save (ESMWriter &esm, bool inInventory = false) const;