mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-03-14 01:19:59 +00:00
Code Issues Projects Releases Wiki Activity

Make RemoveSpellEffects affect permanent spells (bug #3920)

Browse Source 
Also make it remove the effects but not the spells themselves
This commit is contained in:
Capostrophic 2018-08-27 02:17:49 +03:00
parent c280a71b33
commit 6c47f95677
5 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -31,6 +31,7 @@
Bug #3876: Landscape texture painting is misaligned
Bug #3897: Have Goodbye give all choices the effects of Goodbye
Bug #3911: [macOS] Typing in the "Content List name" dialog box produces double characters
Bug #3920: RemoveSpellEffects doesn't remove constant effects
Bug #3948: AiCombat moving target aiming uses incorrect speed for magic projectiles
Bug #3950: FLATTEN_STATIC_TRANSFORMS optimization breaks animated collision shapes
Bug #3993: Terrain texture blending map is not upscaled

8
apps/openmw/mwmechanics/activespells.cpp
View File

@ -197,8 +197,12 @@ namespace MWMechanics
void ActiveSpells::removeEffects(const std::string &id)
{
mSpells.erase(Misc::StringUtils::lowerCase(id));
mSpellsChanged = true;
TContainer::iterator spell(mSpells.find(id));
if (spell != end());
{
spell->second.mEffects.clear();
mSpellsChanged = true;
}
}
void ActiveSpells::visitEffectSources(EffectSourceVisitor &visitor) const

13
apps/openmw/mwmechanics/spells.cpp
View File

@ -279,6 +279,19 @@ namespace MWMechanics
}
}
void Spells::removeEffects(const std::string &id)
{
if (isSpellActive(id))
{
TContainer::iterator spellIt = mSpells.find(getSpell(id));
for (long unsigned int i = 0; i != spellIt->first->mEffects.mList.size(); i++)
{
spellIt->second.mPurgedEffects.insert(i);
mSpellsChanged = true;
}
}
}
void Spells::visitEffectSources(EffectSourceVisitor &visitor) const
{
if (mSpellsChanged) {

2
apps/openmw/mwmechanics/spells.hpp
View File

@ -124,6 +124,8 @@ namespace MWMechanics
bool hasBlightDisease() const;
void removeEffects(const std::string& id);
void visitEffectSources (MWMechanics::EffectSourceVisitor& visitor) const;
void readState (const ESM::SpellState& state);

1
apps/openmw/mwscript/statsextensions.cpp
View File

@ -501,6 +501,7 @@ namespace MWScript
runtime.pop();
ptr.getClass().getCreatureStats (ptr).getActiveSpells().removeEffects(spellid);
ptr.getClass().getCreatureStats (ptr).getSpells().removeEffects(spellid);
}
};