From 5d51f3ea268ddd76750de25efbfe3b741f37ef15 Mon Sep 17 00:00:00 2001 From: Andrei Kortunov Date: Mon, 4 Sep 2023 12:16:47 +0400 Subject: [PATCH] Init structs to make sure that we do not store a random data --- apps/openmw/mwworld/worldmodel.cpp | 7 ++----- components/esm4/reader.cpp | 4 ++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/apps/openmw/mwworld/worldmodel.cpp b/apps/openmw/mwworld/worldmodel.cpp index a488bf0913..b9187f59c4 100644 --- a/apps/openmw/mwworld/worldmodel.cpp +++ b/apps/openmw/mwworld/worldmodel.cpp @@ -53,23 +53,20 @@ namespace MWWorld const ESM::Cell* createEsmCell(ESM::ExteriorCellLocation location, ESMStore& store) { - ESM::Cell record; + ESM::Cell record = {}; record.mData.mFlags = ESM::Cell::HasWater; record.mData.mX = location.mX; record.mData.mY = location.mY; - record.mWater = 0; - record.mMapColor = 0; record.updateId(); return store.insert(record); } const ESM4::Cell* createEsm4Cell(ESM::ExteriorCellLocation location, ESMStore& store) { - ESM4::Cell record; + ESM4::Cell record = {}; record.mParent = location.mWorldspace; record.mX = location.mX; record.mY = location.mY; - record.mCellFlags = 0; return store.insert(record); } diff --git a/components/esm4/reader.cpp b/components/esm4/reader.cpp index 4a78fd21ea..f81a971e15 100644 --- a/components/esm4/reader.cpp +++ b/components/esm4/reader.cpp @@ -169,8 +169,8 @@ namespace ESM4 , currCellGrid(FormId{ 0, 0 }) , cellGridValid(false) { - subRecordHeader.typeId = 0; - subRecordHeader.dataSize = 0; + recordHeader = {}; + subRecordHeader = {}; } Reader::Reader(Files::IStreamPtr&& esmStream, const std::filesystem::path& filename, VFS::Manager const* vfs,