mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-03-16 16:20:53 +00:00
Code Issues Projects Releases Wiki Activity

Add tests for Settings::Values

Browse Source
This commit is contained in:
elsid 2023-04-23 15:15:33 +02:00
parent 1fbf50fb13
commit 499d086cc1
No known key found for this signature in database
GPG Key ID: 4DE04C198CBA7625
2 changed files with 86 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/openmw_test_suite/CMakeLists.txt
View File

@ -57,6 +57,7 @@ file(GLOB UNITTEST_SRC_FILES
settings/parser.cpp
settings/shadermanager.cpp
settings/testvalues.cpp
shader/parsedefines.cpp
shader/parsefors.cpp

85
apps/openmw_test_suite/settings/testvalues.cpp Normal file
View File

@ -0,0 +1,85 @@
#include "components/misc/strings/conversion.hpp"
#include "components/settings/parser.hpp"
#include "components/settings/values.hpp"
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#ifndef OPENMW_PROJECT_SOURCE_DIR
#define OPENMW_PROJECT_SOURCE_DIR "."
#endif
namespace Settings
{
namespace
{
using namespace testing;
struct SettingsValuesTest : Test
{
const std::filesystem::path mSettingsDefaultPath = std::filesystem::path{ OPENMW_PROJECT_SOURCE_DIR }
/ "files" / Misc::StringUtils::stringToU8String("settings-default.cfg");
SettingsValuesTest()
{
Manager::mDefaultSettings.clear();
Manager::mUserSettings.clear();
Manager::mChangedSettings.clear();
SettingsFileParser parser;
parser.loadSettingsFile(mSettingsDefaultPath, Manager::mDefaultSettings);
}
};
TEST_F(SettingsValuesTest, shouldLoadFromSettingsManager)
{
Values values;
EXPECT_EQ(values.mCamera.mFieldOfView.get(), 60);
}
TEST_F(SettingsValuesTest, constructorShouldThrowExceptionOnMissingSetting)
{
Manager::mDefaultSettings.erase({ "Camera", "field of view" });
EXPECT_THROW([] { Values values; }(), std::runtime_error);
}
TEST_F(SettingsValuesTest, constructorShouldSanitize)
{
Manager::mUserSettings[std::make_pair("Camera", "field of view")] = "-1";
Values values;
EXPECT_EQ(values.mCamera.mFieldOfView.get(), 1);
}
TEST_F(SettingsValuesTest, moveConstructorShouldSetDefaults)
{
Values defaultValues;
Manager::mUserSettings.emplace(std::make_pair("Camera", "field of view"), "61");
Values values(std::move(defaultValues));
EXPECT_EQ(values.mCamera.mFieldOfView.get(), 61);
values.mCamera.mFieldOfView.reset();
EXPECT_EQ(values.mCamera.mFieldOfView.get(), 60);
}
TEST_F(SettingsValuesTest, moveConstructorShouldSanitize)
{
Values defaultValues;
Manager::mUserSettings[std::make_pair("Camera", "field of view")] = "-1";
Values values(std::move(defaultValues));
EXPECT_EQ(values.mCamera.mFieldOfView.get(), 1);
}
TEST_F(SettingsValuesTest, setShouldChangeManagerUserSettings)
{
Values values;
values.mCamera.mFieldOfView.set(42);
EXPECT_EQ(Manager::mUserSettings.at({ "Camera", "field of view" }), "42");
EXPECT_THAT(Manager::mChangedSettings, ElementsAre(std::make_pair("Camera", "field of view")));
}
TEST_F(SettingsValuesTest, setShouldNotChangeManagerChangedSettingsForNoChange)
{
Values values;
values.mCamera.mFieldOfView.set(values.mCamera.mFieldOfView.get());
EXPECT_THAT(Manager::mChangedSettings, ElementsAre());
}
}
}