From 3877d227f454add588d04c70c88cfe243395527a Mon Sep 17 00:00:00 2001 From: elsid <elsid.mail@gmail.com> Date: Fri, 28 Jan 2022 01:00:52 +0100 Subject: [PATCH] Avoid unnecessary copies --- components/esm3/stolenitems.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/components/esm3/stolenitems.cpp b/components/esm3/stolenitems.cpp index e196fc80c2..a43ae61a60 100644 --- a/components/esm3/stolenitems.cpp +++ b/components/esm3/stolenitems.cpp @@ -32,15 +32,14 @@ namespace ESM std::map<std::pair<std::string, bool>, int> ownerMap; while (esm.isNextSub("FNAM") || esm.isNextSub("ONAM")) { - std::string subname = esm.retSubName().toString(); + const bool isFaction = (esm.retSubName() == "FNAM"); std::string owner = esm.getHString(); - bool isFaction = (subname == "FNAM"); int count; esm.getHNT(count, "COUN"); - ownerMap.insert(std::make_pair(std::make_pair(owner, isFaction), count)); + ownerMap.emplace(std::make_pair(std::move(owner), isFaction), count); } - mStolenItems[itemid] = ownerMap; + mStolenItems.insert_or_assign(std::move(itemid), std::move(ownerMap)); } }