mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-01-01 03:21:41 +00:00
Code Issues Projects Releases Wiki Activity

Improve null root handling

Browse Source
This commit is contained in:
Dobrohotov Alexei 2021-05-05 02:26:32 +03:00
parent b10a817f7e
commit 19f0b80983
3 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
components/nif/niffile.cpp
View File

@ -322,7 +322,7 @@ void NIFFile::parse(Files::IStreamPtr stream)
else
{
roots[i] = nullptr;
warn("Null Root found");
warn("Root " + std::to_string(i + 1) + " does not point to a record: index " + std::to_string(idx));
}
}

10
components/nifbullet/bulletnifloader.cpp
View File

@ -121,12 +121,14 @@ osg::ref_ptr<Resource::BulletShape> BulletNifLoader::load(const Nif::File& nif)
mAvoidStaticMesh.reset();
const size_t numRoots = nif.numRoots();
std::vector<Nif::Node*> roots;
std::vector<const Nif::Node*> roots;
for (size_t i = 0; i < numRoots; ++i)
{
Nif::Record* r = nif.getRoot(i);
assert(r != nullptr);
if (Nif::Node* node = dynamic_cast<Nif::Node*>(r))
const Nif::Record* r = nif.getRoot(i);
if (!r)
continue;
const Nif::Node* node = dynamic_cast<const Nif::Node*>(r);
if (node)
roots.emplace_back(node);
}
const std::string filename = nif.getFilename();

8
components/nifosg/nifloader.cpp
View File

@ -254,8 +254,7 @@ namespace NifOsg
for (size_t i = 0; i < numRoots; ++i)
{
const Nif::Record *r = nif->getRoot(i);
assert(r != nullptr);
if (r->recType == Nif::RC_NiSequenceStreamHelper)
if (r && r->recType == Nif::RC_NiSequenceStreamHelper)
{
seq = static_cast<const Nif::NiSequenceStreamHelper*>(r);
break;
@ -312,7 +311,10 @@ namespace NifOsg
for (size_t i = 0; i < numRoots; ++i)
{
const Nif::Record* r = nif->getRoot(i);
if (const Nif::Node* nifNode = dynamic_cast<const Nif::Node*>(r))
if (!r)
continue;
const Nif::Node* nifNode = dynamic_cast<const Nif::Node*>(r);
if (nifNode)
roots.emplace_back(nifNode);
}
if (roots.empty())