mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-02-25 03:40:40 +00:00
Code Issues Projects Releases Wiki Activity

Throw exception if moveTo() is passed an object not part of *this

Browse Source
This commit is contained in:
scrawl 2015-12-06 20:05:13 +01:00
parent 176a3c16f4
commit 0af33b5abd
1 changed files with 31 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
apps/openmw/mwworld/cellstore.cpp
View File

@ -144,6 +144,28 @@ namespace
ref.load (state); ref.load (state);
collection.mList.push_back (ref); collection.mList.push_back (ref);
} }
struct SearchByRefNumVisitor
{
MWWorld::LiveCellRefBase* mFound;
ESM::RefNum mRefNumToFind;
SearchByRefNumVisitor(const ESM::RefNum& toFind)
: mFound(NULL)
, mRefNumToFind(toFind)
{
}
bool operator()(const MWWorld::Ptr& ptr)
{
if (ptr.getCellRef().getRefNum() == mRefNumToFind)
{
mFound = ptr.getBase();
return false;
}
return true;
}
};
} }
namespace MWWorld namespace MWWorld
@ -205,13 +227,18 @@ namespace MWWorld
MWWorld::Ptr CellStore::moveTo(const Ptr &object, CellStore *cellToMoveTo) MWWorld::Ptr CellStore::moveTo(const Ptr &object, CellStore *cellToMoveTo)
{ {
if (cellToMoveTo == this) if (cellToMoveTo == this)
throw std::runtime_error("object is already in this cell"); throw std::runtime_error("moveTo: object is already in this cell");
// We assume that *this is in State_Loaded since we could hardly have reference to a live object otherwise. // We assume that *this is in State_Loaded since we could hardly have reference to a live object otherwise.
if (mState != State_Loaded) if (mState != State_Loaded)
throw std::runtime_error("can't move object from a non-loaded cell (how did you get this object anyway?)"); throw std::runtime_error("moveTo: can't move object from a non-loaded cell (how did you get this object anyway?)");
// Ensure that the object actually exists in the cell
SearchByRefNumVisitor searchVisitor(object.getCellRef().getRefNum());
forEach(searchVisitor);
if (!searchVisitor.mFound)
throw std::runtime_error("moveTo: object is not in this cell");
// TODO: ensure that the object actually exists in the cell
// Objects with no refnum can't be handled correctly in the merging process that happens // Objects with no refnum can't be handled correctly in the merging process that happens
// on a save/load, so do a simple copy & delete for these objects. // on a save/load, so do a simple copy & delete for these objects.
@ -613,28 +640,6 @@ namespace MWWorld
mFogState->load(reader); mFogState->load(reader);
} }
struct SearchByRefNumVisitor
{
LiveCellRefBase* mFound;
ESM::RefNum mRefNumToFind;
SearchByRefNumVisitor(const ESM::RefNum& toFind)
: mFound(NULL)
, mRefNumToFind(toFind)
{
}
bool operator()(const MWWorld::Ptr& ptr)
{
if (ptr.getCellRef().getRefNum() == mRefNumToFind)
{
mFound = ptr.getBase();
return false;
}
return true;
}
};
void CellStore::writeReferences (ESM::ESMWriter& writer) const void CellStore::writeReferences (ESM::ESMWriter& writer) const
{ {
writeReferenceCollection<ESM::ObjectState> (writer, mActivators); writeReferenceCollection<ESM::ObjectState> (writer, mActivators);
@ -830,6 +835,7 @@ namespace MWWorld
if (otherCell == this) if (otherCell == this)
{ {
// Should never happen unless someone's tampering with files.
std::cerr << "Found invalid moved ref, ignoring" << std::endl; std::cerr << "Found invalid moved ref, ignoring" << std::endl;
continue; continue;
} }