From e65af0bf0678c925efafe0987608fa56d45893c9 Mon Sep 17 00:00:00 2001 From: Bret Curtis Date: Sat, 23 Oct 2021 10:48:37 +0200 Subject: [PATCH 1/5] Silence all opengl deprecation warnings for MacOS We know... --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 0451b639e5..1ae3841bdd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -707,6 +707,7 @@ endif() if (BUILD_OPENMW AND APPLE) # Without these flags LuaJit crashes on startup on OSX set_target_properties(openmw PROPERTIES LINK_FLAGS "-pagezero_size 10000 -image_base 100000000") + set_target_properties(components PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") endif() # Apple bundling From 62b59a3c001d43c5468b1e17b8a40fe8015d40d1 Mon Sep 17 00:00:00 2001 From: Bret Curtis Date: Sat, 23 Oct 2021 12:56:02 +0200 Subject: [PATCH 2/5] Update CMakeLists.txt --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1ae3841bdd..537c90670d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -708,6 +708,7 @@ if (BUILD_OPENMW AND APPLE) # Without these flags LuaJit crashes on startup on OSX set_target_properties(openmw PROPERTIES LINK_FLAGS "-pagezero_size 10000 -image_base 100000000") set_target_properties(components PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") + set_target_properties(openmw PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") endif() # Apple bundling From cd358ce1f999c267e61eb57533379bcf8611ffa8 Mon Sep 17 00:00:00 2001 From: Bret Curtis Date: Wed, 27 Oct 2021 11:48:17 +0200 Subject: [PATCH 3/5] Update CMakeLists.txt --- CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 537c90670d..13196a4aa6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -707,8 +707,7 @@ endif() if (BUILD_OPENMW AND APPLE) # Without these flags LuaJit crashes on startup on OSX set_target_properties(openmw PROPERTIES LINK_FLAGS "-pagezero_size 10000 -image_base 100000000") - set_target_properties(components PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") - set_target_properties(openmw PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") + set_target_properties(components openmw PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") endif() # Apple bundling From 1a51c6eb5dfe4e4a95fa9ec99a9a16ce9f0b6bd3 Mon Sep 17 00:00:00 2001 From: Bret Curtis Date: Wed, 27 Oct 2021 23:40:54 +0200 Subject: [PATCH 4/5] Update CMakeLists.txt --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 13196a4aa6..49f3f4b3bf 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -707,7 +707,7 @@ endif() if (BUILD_OPENMW AND APPLE) # Without these flags LuaJit crashes on startup on OSX set_target_properties(openmw PROPERTIES LINK_FLAGS "-pagezero_size 10000 -image_base 100000000") - set_target_properties(components openmw PROPERTIES COMPILE_DEFINITIONS "GL_SILENCE_DEPRECATION=1") + add_compile_definitions(GL_SILENCE_DEPRECATION=1) endif() # Apple bundling From fa5581942eb5019f84b866f038741d4ff9b692ba Mon Sep 17 00:00:00 2001 From: Bret Curtis Date: Wed, 27 Oct 2021 23:54:04 +0200 Subject: [PATCH 5/5] Update CMakeLists.txt --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 49f3f4b3bf..1b4e5609ae 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -707,7 +707,8 @@ endif() if (BUILD_OPENMW AND APPLE) # Without these flags LuaJit crashes on startup on OSX set_target_properties(openmw PROPERTIES LINK_FLAGS "-pagezero_size 10000 -image_base 100000000") - add_compile_definitions(GL_SILENCE_DEPRECATION=1) + target_compile_definitions(components PRIVATE GL_SILENCE_DEPRECATION=1) + target_compile_definitions(openmw PRIVATE GL_SILENCE_DEPRECATION=1) endif() # Apple bundling